Closed Bug 1204995 Opened 6 years ago Closed 6 years ago

Telemetry probe to know what % of people have "open external links in private tabs" enabled

Categories

(Firefox for Android Graveyard :: Settings and Preferences, defect)

35 Branch
defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file)

We made this feature, let's know how many people actually use it.
Bug 1204995 - Add telemetry histogram probe to know what % of people have "open external links in private tabs" enabled. r?mcomella
Attachment #8661775 - Flags: review?(michael.l.comella)
Comment on attachment 8661775 [details]
MozReview Request: Bug 1204995 - Update FENNEC_OPEN_URLS_IN_PRIVATE expires_in_version value to actually collect data. r=mfinkle

https://reviewboard.mozilla.org/r/19445/#review17479

::: toolkit/components/telemetry/Histograms.json:8828
(Diff revision 1)
> +    "description": "Reports the state of the open external links in private tabs preference"

You should add an `alert_email` here. See bug 1198955 where I remove such a probe.
Attachment #8661775 - Flags: review?(michael.l.comella) → review+
https://reviewboard.mozilla.org/r/19445/#review17485

::: mobile/android/base/BrowserApp.java:1868
(Diff revision 1)
> +            Telemetry.addToHistogram("FENNEC_OPEN_URLS_IN_PRIVATE", (openPrivate ? 1 : 0));

This probably works well enough, and we use "boolean" for other similar probes. I wonder if this overcounts though. We wanted to add "flag" support too. Food for thought.

::: toolkit/components/telemetry/Histograms.json:8825
(Diff revision 1)
> +  "FENNEC_OPEN_URLS_IN_PRIVATE": {

Technically, this needs a p? from a privacy/telemetry person. Ally or Vladan would be fine and should be very responsive. Ping on IRC if needed.
Also, does this probe pass/fail the test (do we have a test?) for tracking Private Browsing behavior? Technically, we are not tracking when the user opens a PB tab with this probe, just whether the preference is set.
Comment on attachment 8661775 [details]
MozReview Request: Bug 1204995 - Update FENNEC_OPEN_URLS_IN_PRIVATE expires_in_version value to actually collect data. r=mfinkle

(In reply to Mark Finkle (:mfinkle) from comment #4)
> Also, does this probe pass/fail the test (do we have a test?) for tracking
> Private Browsing behavior? Technically, we are not tracking when the user
> opens a PB tab with this probe, just whether the preference is set.

I assumed it would be okay because it is just measuring whether or not a preference is set, but let's check with bsmedberg to be thorough. I also still need to request a telemetry review from a data steward on this.

This feature is only on Nightly, and I'm going to have the probe set to expire in a release, so that we collect the minimum amount of data necessary to understand whether or not people are using this feature. I am prepared to argue that this probe is important for helping us understand how people are using the new privacy features we're trying to develop.
Attachment #8661775 - Flags: review?(benjamin)
Comment on attachment 8661775 [details]
MozReview Request: Bug 1204995 - Update FENNEC_OPEN_URLS_IN_PRIVATE expires_in_version value to actually collect data. r=mfinkle

This is fine, because it's a setting that doesn't indicate that you've used PB, and it's already recorded on the user's disk.
Attachment #8661775 - Flags: review?(benjamin) → review+
(In reply to Mark Finkle (:mfinkle) from comment #3)
> https://reviewboard.mozilla.org/r/19445/#review17485
> 
> ::: mobile/android/base/BrowserApp.java:1868
> (Diff revision 1)
> > +            Telemetry.addToHistogram("FENNEC_OPEN_URLS_IN_PRIVATE", (openPrivate ? 1 : 0));
> 
> This probably works well enough, and we use "boolean" for other similar
> probes. I wonder if this overcounts though. We wanted to add "flag" support
> too. Food for thought.

I thought we had problems with trying to use "flag" in the past... but it looks like this might answer my question:
https://bugzilla.mozilla.org/show_bug.cgi?id=1170137#c2
Updated try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=aaa79329a816

I updated this to use a flag, but want to make sure there isn't anything else causing bug 1170137. I also set the probe to expire in 44, since I probably won't get around to landing this until next week.
NI for landing
Flags: needinfo?(margaret.leibovic)
(In reply to Mark Finkle (:mfinkle) from comment #10)
> NI for landing

My try push is pretty orange... it seems unrelated, but I'm going to make another one to be sure, since retriggers don't seem to be resolving it.
Flags: needinfo?(margaret.leibovic)
(In reply to :Margaret Leibovic from comment #11)
> (In reply to Mark Finkle (:mfinkle) from comment #10)
> > NI for landing
> 
> My try push is pretty orange... it seems unrelated, but I'm going to make
> another one to be sure, since retriggers don't seem to be resolving it.

Actually, I was confused by the way treeherder now collpases passing tests... there are passing test runs, and it seems like the failures really are just awful intermittents related to service workers.
https://hg.mozilla.org/integration/fx-team/rev/df9dfa4138ed4c7864fe6e55f1ab41f10eb30c35
Bug 1204995 - Add telemetry histogram probe to know what % of people have "open external links in private tabs" enabled. r=mcomella r=bsmedberg
https://hg.mozilla.org/mozilla-central/rev/df9dfa4138ed
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment on attachment 8661775 [details]
MozReview Request: Bug 1204995 - Update FENNEC_OPEN_URLS_IN_PRIVATE expires_in_version value to actually collect data. r=mfinkle

Bug 1204995 - Update FENNEC_OPEN_URLS_IN_PRIVATE expires_in_version value to actually collect data. r=mfinkle
Attachment #8661775 - Attachment description: MozReview Request: Bug 1204995 - Add telemetry histogram probe to know what % of people have "open external links in private tabs" enabled. r?mcomella → MozReview Request: Bug 1204995 - Update FENNEC_OPEN_URLS_IN_PRIVATE expires_in_version value to actually collect data. r=mfinkle
Attachment #8661775 - Flags: review+ → review?(mark.finkle)
Comment on attachment 8661775 [details]
MozReview Request: Bug 1204995 - Update FENNEC_OPEN_URLS_IN_PRIVATE expires_in_version value to actually collect data. r=mfinkle

https://reviewboard.mozilla.org/r/19445/#review19121
Attachment #8661775 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/integration/fx-team/rev/106a6e4b877e66969129018e034a1c1067ee8aa1
Bug 1204995 - Update FENNEC_OPEN_URLS_IN_PRIVATE expires_in_version value to actually collect data. r=mfinkle
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.