1205126 - Tint checkbox preferences on Honeycomb - KitKat

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

A side effect of bug 1201206 is that the checkbox preferences on Honeycomb - KitKat are black – let's tint them (after bug 1205124 lands)!

Some theories from bug 1201206 comment 10:

I was unable to correct the color of the black Material checkboxes. It is my
impression that AppCompat-users need to extend ActionBarActivity (which can use
PreferenceFragment) to make full use of the features, meaning GeckoPreferences
needs to extend ActionBarActivity (which is too much scope-creeping here).

For more info:
* The new checkboxes that are tint capable are introduced in:
http://android-developers.blogspot.com/2014/10/appcompat-v21-material-design-for-pre.html
* The docs indicate you can change this dynamically or via xml attr:
https://developer.android.com/reference/android/support/v7/widget/AppCompatCheckBox.html
* This post indicates all that is needed is colorAccent (AppCompatCheckBox
should be used automatically, according to other docs):
http://stackoverflow.com/a/31110775
* This post agrees with the above post: http://stackoverflow.com/a/26850668

Comment 1

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Here's what the menu looks like now: https://bug1201206.bmoattachments.org/attachment.cgi?id=8661541

Comment 2

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

I can't find which bug this was fixed in but my Android 4.* GS4 uses Holo checkboxes in Settings.