Closed Bug 1205212 Opened 9 years ago Closed 9 years ago

Implement new Pin card

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: apastor, Assigned: apastor)

References

Details

(Whiteboard: [systemsfe])

Attachments

(3 files)

Depends on: 1197865
Assignee: nobody → apastor
Comment on attachment 8662922 [details] [review]
[gaia] albertopq:1205212-new-pin-card > mozilla-b2g:master

Eric, could you please take a look? Thanks!
Attachment #8662922 - Flags: ui-review?(epang)
Comment on attachment 8662922 [details] [review]
[gaia] albertopq:1205212-new-pin-card > mozilla-b2g:master

Thanks for working on this Alberto!

I'm marking as R- since there are some changes needed.  I'll attach an image with my review.
Attachment #8662922 - Flags: ui-review?(epang) → ui-review-
Attached image pin card - review.jpg
Attached are the changes needed.  Let me know if you have any question!  Feel free to ping me for review when the changes are ready :)
Flags: needinfo?(apastor)
Attached image test.png
Attached a screenshot with a pin card with some copy. Right now, we are not getting any meta data from the pages, so we only add the title. I thought it didn't make sense to spend time in all the options if they are still not implemented, so only Title and Copy are in right now
Flags: needinfo?(apastor)
Comment on attachment 8662922 [details] [review]
[gaia] albertopq:1205212-new-pin-card > mozilla-b2g:master

Eric, could you please take a second look? I'll work in the favicon in a different bug, as it affects to other places (site icon, homescreen..) Thanks!
Attachment #8662922 - Flags: ui-review- → ui-review?(epang)
Comment on attachment 8662922 [details] [review]
[gaia] albertopq:1205212-new-pin-card > mozilla-b2g:master

R+ 
Since outstanding issues will be fixed in other bugs

Thanks Alberto for the hard work!
Attachment #8662922 - Flags: ui-review?(epang) → ui-review+
Comment on attachment 8662922 [details] [review]
[gaia] albertopq:1205212-new-pin-card > mozilla-b2g:master

Guillaume, could you please take a look? Thanks!
Attachment #8662922 - Flags: review?(gmarty)
Comment on attachment 8662922 [details] [review]
[gaia] albertopq:1205212-new-pin-card > mozilla-b2g:master

R+ with a question left on Github.
Attachment #8662922 - Flags: review?(gmarty) → review+
Replied and amended comment. Thanks!

master: https://github.com/mozilla-b2g/gaia/commit/738d74f9a0357749303d4987ccfa550d3aa9d151
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: