1205212 - Implement new Pin card

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alberto Pastor [:albertopq]]

Implement the new gaia pin card spec:

https://mozilla.app.box.com/s/ut3mgd12q0kn4wnyfc5f5wmy34ydnppx

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1205212-new-pin-card > mozilla-b2g:master

Comment 2

[Alberto Pastor [:albertopq]]

Comment on attachment 8662922 [details] [review]
[gaia] albertopq:1205212-new-pin-card > mozilla-b2g:master

Eric, could you please take a look? Thanks!

Comment 3

[Eric Pang [:epang] UX]

Comment on attachment 8662922 [details] [review]
[gaia] albertopq:1205212-new-pin-card > mozilla-b2g:master

Thanks for working on this Alberto!

I'm marking as R- since there are some changes needed.  I'll attach an image with my review.

Comment 4

[Eric Pang [:epang] UX]

Attachment: pin card - review.jpg

Attached are the changes needed.  Let me know if you have any question!  Feel free to ping me for review when the changes are ready :)

Comment 5

[Alberto Pastor [:albertopq]]

Attachment: test.png

Attached a screenshot with a pin card with some copy. Right now, we are not getting any meta data from the pages, so we only add the title. I thought it didn't make sense to spend time in all the options if they are still not implemented, so only Title and Copy are in right now

Comment 6

[Alberto Pastor [:albertopq]]

Comment on attachment 8662922 [details] [review]
[gaia] albertopq:1205212-new-pin-card > mozilla-b2g:master

Eric, could you please take a second look? I'll work in the favicon in a different bug, as it affects to other places (site icon, homescreen..) Thanks!

Comment 7

[Eric Pang [:epang] UX]

Comment on attachment 8662922 [details] [review]
[gaia] albertopq:1205212-new-pin-card > mozilla-b2g:master

R+ 
Since outstanding issues will be fixed in other bugs

Thanks Alberto for the hard work!

Comment 8

[Alberto Pastor [:albertopq]]

Comment on attachment 8662922 [details] [review]
[gaia] albertopq:1205212-new-pin-card > mozilla-b2g:master

Guillaume, could you please take a look? Thanks!

Comment 10

[Guillaume Marty [:gmarty]]

Comment on attachment 8662922 [details] [review]
[gaia] albertopq:1205212-new-pin-card > mozilla-b2g:master

R+ with a question left on Github.

Comment 11

[Alberto Pastor [:albertopq]]

Replied and amended comment. Thanks!

master: https://github.com/mozilla-b2g/gaia/commit/738d74f9a0357749303d4987ccfa550d3aa9d151