Closed Bug 1205249 Opened 4 years ago Closed 4 years ago

disable jemalloc 4 days before the uplift, and reneable it 1 day after the uplift

Categories

(Testing :: Talos, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

in order to help see what regressions we really have on the uplift, we will disable jemalloc for a couple days and then re-enable it once we have the uplift complete.

This is how to disable jemalloc:
hg backout 8b380feae2ae

we will do this Thursday AM, and re-enable Monday evening.

This will generate hundreds of alerts (improvement alerts on backout, and new regression alerts on re-enabling).
Assignee: nobody → jmaher
Can you post new alertmanager links in bug 1138999 when you get them? I landed something between the backout and the backout of the backout that should have affected the regressions, hopefully in the right direction.
the latest alerts are here:
http://alertmanager.allizom.org:8080/alerts.html?rev=949d31ea7ce7529eb3316f7094d51ff56e099c82&showAll=1&testIndex=0&platIndex=0

less overall alerts, a few seem higher- I broke talos for 5 pushes whilst landing jemalloc4- I am not 100% sure if any of this is related to the few other pushes in there.
Just a heads up: I'm seeing a 25MiB AWSY regression when re-enabling jemalloc 4 in https://hg.mozilla.org/integration/mozilla-inbound/rev/fb84d1d1d9f3
this will happen tomorrow- the trees have been closed all day.
Depends on: 1219914
(In reply to Joel Maher (:jmaher) from comment #6)
> this will happen tomorrow- the trees have been closed all day.

Once disabled again we might want to hold of on re-enabling until bug 1219914 gets resolved.
joy, I learned after landing this that the uplift happened yesterday.  This was a last minute change in plans.  It will be interesting to see how the alerts line up- I will hack on this project on Monday !
:erahm, are there action items on bug 1219914?  I don't see much on there, but it was just filed.  I can wait to re-enable this if we all agree, it is on my calendar for Tuesday.
(In reply to Joel Maher (:jmaher) from comment #10)
> :erahm, are there action items on bug 1219914?  I don't see much on there,
> but it was just filed.  I can wait to re-enable this if we all agree, it is
> on my calendar for Tuesday.

I guess the action item is to figure what changed during that period, or at least identify where the memory is being held. I've ni'd glandium, hopefully we can get some more details this week.
ok, I will wait on re-enabling this then- it would be nice to get this on sometime this week though.
I am going to close this out as there are no action items to do for this release.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Depends on: CVE-2016-1962
You need to log in before you can comment on or make changes to this bug.