1205286 - About:home sync icon should link to about:preferences#sync

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P1)

Description

[Ryan Feeley [:rfeeley]]

About:home sync icon should open about:preferences#sync in a new tab but currently links to about:accounts?entrypoint=abouthome (not in a new tab)

Comment 1

[Chris Karlof [:ckarlof]]

It does link to the Sync pref pane in the logged in state, but links to about:accounts in the logged out state.

Comment 2

[Ryan Feeley [:rfeeley]]

It should link to about:preferences#sync in both cases. Zach please come to the rescue! This bug keeps showing up in user testing.

Comment 3

[Zachary Carter [:zaach]]

Attachment: Make about:home Sync icon always link to about:preferences#sync

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8667067 [details] [diff] [review]
Make about:home Sync icon always link to about:preferences#sync

Review of attachment 8667067 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great, although we do still need the entrypoint functionality (sorry - I probably mislead you about that) - see https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser-fxaccounts.js#473 for an example. If you add that tweak (including having the test check that) it will be golden!

Comment 5

[Zachary Carter [:zaach]]

Attachment: Make about:home Sync icon always link to about:preferences#sync

Add the entrypoint.

Comment 6

[Zachary Carter [:zaach]]

Attachment: Make about:home Sync icon always link to about:preferences#sync

Comment 7

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8667437 [details] [diff] [review]
Make about:home Sync icon always link to about:preferences#sync

Review of attachment 8667437 [details] [diff] [review]:
-----------------------------------------------------------------

awesome

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f2acd473d59

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5f2acd473d59

Comment 10

[Forhad Hossain]

I have reproduced the bug in nightly 43.0a1 (2015-09-16)(Build ID:20150916030203) with the instruction from comment 0 and linux lite 32 bit

Bug is fixed now on latest nightly 44.0a1 (2015-10-14)(Build ID:20151014030223)
User Agent : Mozilla/5.0 (X11; Linux i686; rv:44.0) Gecko/20100101 Firefox/44.0

[bugday-20151014]

Comment 11

[Ashickur Rahman]

I have reproduced the bug in Firefox 42.0; Build ID :20151029151421;  User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:42.0) Gecko/20100101 Firefox/42.0 .

The fix works for me in Firefox 44.0a2; Build ID: 20151103004217; User Agent : Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:44.0) Gecko/20100101 Firefox/44.0 .

From comment 10 , it seems that the fix is also verified in Linux i686. I am marking the bug as verified.