implement and test fetch spec changes for blob scheme with non-GET method

RESOLVED FIXED in Firefox 46

Status

()

defect
RESOLVED FIXED
4 years ago
4 months ago

People

(Reporter: bkelly, Assigned: dimi)

Tracking

(Blocks 1 bug)

32 Branch
mozilla46
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

See:

  https://github.com/whatwg/fetch/issues/125

Basically a non-GET Request for a blob: scheme URL should result in a NetworkError.  Its possible we already implement this, but we should write a test.  Preferably a WPT test.
Assignee

Comment 1

4 years ago
I would like to take this bug.
Assignee: nobody → dlee
Status: NEW → ASSIGNED
Assignee

Comment 2

4 years ago
Hi Ben,
I add a mochitest for this because there is already tests for fetch blob. please let me know if you prefer also adding a WPT.
Attachment #8704047 - Flags: review?(bkelly)
Comment on attachment 8704047 [details] [diff] [review]
Patch - check non-GET for blob, with mochitest

Review of attachment 8704047 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  Thanks!

Do you know if we check this in XHR as well?
Attachment #8704047 - Flags: review?(bkelly) → review+
Assignee

Comment 4

4 years ago
(In reply to Ben Kelly [:bkelly] from comment #3)
> Comment on attachment 8704047 [details] [diff] [review]
> Patch - check non-GET for blob, with mochitest
> 
> Review of attachment 8704047 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good.  Thanks!
> 
> Do you know if we check this in XHR as well?

No, i write a test and blob is load successfully with POST.
Assignee

Updated

4 years ago
Keywords: checkin-needed

Comment 7

4 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4f4ef7073bb5
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
See Also: → 1238007
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.