Closed Bug 1205288 Opened 5 years ago Closed 5 years ago

implement and test fetch spec changes for blob scheme with non-GET method

Categories

(Core :: DOM: Core & HTML, defect)

32 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: bkelly, Assigned: dimi)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

See:

  https://github.com/whatwg/fetch/issues/125

Basically a non-GET Request for a blob: scheme URL should result in a NetworkError.  Its possible we already implement this, but we should write a test.  Preferably a WPT test.
I would like to take this bug.
Assignee: nobody → dlee
Status: NEW → ASSIGNED
Hi Ben,
I add a mochitest for this because there is already tests for fetch blob. please let me know if you prefer also adding a WPT.
Attachment #8704047 - Flags: review?(bkelly)
Comment on attachment 8704047 [details] [diff] [review]
Patch - check non-GET for blob, with mochitest

Review of attachment 8704047 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  Thanks!

Do you know if we check this in XHR as well?
Attachment #8704047 - Flags: review?(bkelly) → review+
(In reply to Ben Kelly [:bkelly] from comment #3)
> Comment on attachment 8704047 [details] [diff] [review]
> Patch - check non-GET for blob, with mochitest
> 
> Review of attachment 8704047 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good.  Thanks!
> 
> Do you know if we check this in XHR as well?

No, i write a test and blob is load successfully with POST.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4f4ef7073bb5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
See Also: → 1238007
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.