Closed Bug 1205328 Opened 6 years ago Closed 6 years ago
win32 build failure in Regexp
AST .h because of a conflicting macro "min"
When doing try builds for bug 1181612, i've got consistent reproducible failures in irregexp/RegexpAST.h: a syntax error first, and then everybody loses their mind. https://treeherder.mozilla.org/logviewer.html#?job_id=11518343&repo=try https://treeherder.mozilla.org/logviewer.html#?job_id=11518342&repo=try https://treeherder.mozilla.org/logviewer.html#?job_id=11518340&repo=try https://treeherder.mozilla.org/logviewer.html#?job_id=11518341&repo=try The worrying fact is that the line right above the first error says: 04:46:04 INFO - c:\builds\moz2_slave\try-w64-0000000000000000000000\build\src\js\src\irregexp/RegExpAST.h(315) : warning C4003: not enough actual parameters for macro 'min' And we indeed have a few 'min' and 'max' macros in the tree. I think this is happening because adding a few files to the build system slightly moved the unified files including, but that's a wild guess. Try to reproduce the behavior with a simple file: https://treeherder.mozilla.org/#/jobs?repo=try&revision=60efe0174a06
Alternatively, undef'ing min/max in irregexp/RegExpAST.h, but that sounds hacky: https://treeherder.mozilla.org/#/jobs?repo=try&revision=347bc21d583f
You need to log in before you can comment on or make changes to this bug.