Replace nsBaseHashtable::Enumerate() calls in dom/media/ with iterators

RESOLVED FIXED in Firefox 44

Status

()

P2
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
+++ This bug was initially created as a clone of Bug #1186813 +++

Because iterators are so much nicer than enumerate functions.

There are nine occurrences of Enumerate() in this directory.

A note to the assignee: to preserve existing behaviour, you should probably use
nsBaseHashtable::Iterator::Data() rather than nsBaseHashtable::Iterator::UserData(). (The latter should be used when replacing nsBaseHashtable::EnumerateRead()).
(Assignee)

Updated

3 years ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Comment 1

3 years ago
Created attachment 8662006 [details] [diff] [review]
patch - Replace nsBaseHashtable::Enumerate() calls in dom/media/ with iterators
(Assignee)

Comment 2

3 years ago
Created attachment 8662016 [details] [diff] [review]
patch - Replace nsBaseHashtable::Enumerate() calls in dom/media/ with iterators

Update nits.
Attachment #8662006 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8662016 - Flags: review?(cpearce)
Attachment #8662016 - Flags: review?(cpearce) → review+
Component: Audio/Video → Audio/Video: Playback
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/c64634725cac
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.