Closed Bug 1205558 Opened 6 years ago Closed 6 years ago

track audio node engine time only on the destination node

Categories

(Core :: Web Audio, defect, P1)

43 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- affected
firefox44 --- fixed

People

(Reporter: karlt, Assigned: karlt)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

In order to suspend inactive audio node streams for bug 1189562, the suspend time would need to be accounted.  A simple way to do that is to instead look to the stream for the AudioDestinationNode for the current time.  This already needs to happen when converting DOM times.

Managing the track appears to be a significant part of overhead of processing.
See FindTrack() and AdvanceOutputSegment() in bug 1205540 comment 1.
If current time is tracked on the destination node engine, then non-external audio nodes should not need a track at all.
Rank: 5
Priority: -- → P1
No longer blocks: 1172997
Depends on: 1207003
bug 1205558 introduce SecondsToNearestStreamTime r?padenot
Attachment #8667124 - Flags: review?(padenot)
bug 1205558 use destination stream for audio node engine time r?padenot
Attachment #8667125 - Flags: review?(padenot)
bug 1205558 remove unused AudioNodeStream* aSource parameter r?padenot
Attachment #8667126 - Flags: review?(padenot)
bug 1205558 remove unnecessary ScriptProcessorNodeEngine::mSource r?padenot
Attachment #8667127 - Flags: review?(padenot)
bug 1205558 remove DelayNodeEngine::mSource r?padenot
Attachment #8667128 - Flags: review?(padenot)
Comment on attachment 8667124 [details]
MozReview Request: bug 1205558 introduce SecondsToNearestStreamTime r?padenot

https://reviewboard.mozilla.org/r/20675/#review18535
Attachment #8667124 - Flags: review?(padenot) → review+
Comment on attachment 8667125 [details]
MozReview Request: bug 1205558 use destination stream for audio node engine time r?padenot

https://reviewboard.mozilla.org/r/20677/#review18537
Attachment #8667125 - Flags: review?(padenot) → review+
Comment on attachment 8667126 [details]
MozReview Request: bug 1205558 remove unused AudioNodeStream* aSource parameter r?padenot

https://reviewboard.mozilla.org/r/20679/#review18539
Attachment #8667126 - Flags: review?(padenot) → review+
Comment on attachment 8667127 [details]
MozReview Request: bug 1205558 remove unnecessary ScriptProcessorNodeEngine::mSource r?padenot

https://reviewboard.mozilla.org/r/20681/#review18541
Attachment #8667127 - Flags: review?(padenot) → review+
Attachment #8667128 - Flags: review?(padenot) → review+
Comment on attachment 8667128 [details]
MozReview Request: bug 1205558 remove DelayNodeEngine::mSource r?padenot

https://reviewboard.mozilla.org/r/20683/#review18543
Depends on: 1214493
Flags: in-testsuite-
Depends on: 1221889
No longer depends on: 1221889
Regressions: 1221889
You need to log in before you can comment on or make changes to this bug.