1205558 - track audio node engine time only on the destination node

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P1)

Description

[Karl Tomlinson (:karlt)]

In order to suspend inactive audio node streams for bug 1189562, the suspend time would need to be accounted.  A simple way to do that is to instead look to the stream for the AudioDestinationNode for the current time.  This already needs to happen when converting DOM times.

Managing the track appears to be a significant part of overhead of processing.
See FindTrack() and AdvanceOutputSegment() in bug 1205540 comment 1.
If current time is tracked on the destination node engine, then non-external audio nodes should not need a track at all.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1205558 introduce SecondsToNearestStreamTime r?padenot

bug 1205558 introduce SecondsToNearestStreamTime r?padenot

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1205558 use destination stream for audio node engine time r?padenot

bug 1205558 use destination stream for audio node engine time r?padenot

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1205558 remove unused AudioNodeStream* aSource parameter r?padenot

bug 1205558 remove unused AudioNodeStream* aSource parameter r?padenot

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1205558 remove unnecessary ScriptProcessorNodeEngine::mSource r?padenot

bug 1205558 remove unnecessary ScriptProcessorNodeEngine::mSource r?padenot

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1205558 remove DelayNodeEngine::mSource r?padenot

bug 1205558 remove DelayNodeEngine::mSource r?padenot

Comment 6

[Paul Adenot (:padenot)]

Comment on attachment 8667124 [details]
MozReview Request: bug 1205558 introduce SecondsToNearestStreamTime r?padenot

https://reviewboard.mozilla.org/r/20675/#review18535

Comment 7

[Paul Adenot (:padenot)]

Comment on attachment 8667125 [details]
MozReview Request: bug 1205558 use destination stream for audio node engine time r?padenot

https://reviewboard.mozilla.org/r/20677/#review18537

Comment 8

[Paul Adenot (:padenot)]

Comment on attachment 8667126 [details]
MozReview Request: bug 1205558 remove unused AudioNodeStream* aSource parameter r?padenot

https://reviewboard.mozilla.org/r/20679/#review18539

Comment 9

[Paul Adenot (:padenot)]

Comment on attachment 8667127 [details]
MozReview Request: bug 1205558 remove unnecessary ScriptProcessorNodeEngine::mSource r?padenot

https://reviewboard.mozilla.org/r/20681/#review18541

Comment 10

[Paul Adenot (:padenot)]

Comment on attachment 8667128 [details]
MozReview Request: bug 1205558 remove DelayNodeEngine::mSource r?padenot

https://reviewboard.mozilla.org/r/20683/#review18543

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c47751b43a71
https://hg.mozilla.org/integration/mozilla-inbound/rev/13e85dc6b41b
https://hg.mozilla.org/integration/mozilla-inbound/rev/983347f21a23
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd555b8702ca
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1f82e673a34

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c47751b43a71
https://hg.mozilla.org/mozilla-central/rev/13e85dc6b41b
https://hg.mozilla.org/mozilla-central/rev/983347f21a23
https://hg.mozilla.org/mozilla-central/rev/cd555b8702ca
https://hg.mozilla.org/mozilla-central/rev/f1f82e673a34