1205621 - arm64: propagate OOM from calls to buffer.allocEntry

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Lars T Hansen [:lth]]

See bug 1186982.  Calls to allocEntry() need to check the result, if the result value is a dummy (unassigned) value then OOM should be signaled via propagateOOM().

On ARM32 there's now one call to allocEntry but ARM64 appears to have several.

Comment 1

[Jakob Stoklund Olesen [:jolesen]]

This seems like a fine thing for me to work on once I get SM(arm64) into treeherder.

Comment 2

[Jakob Stoklund Olesen [:jolesen]]

Attachment: arm64: Handle OOMs in a safer manner.

When inserting instructions that encode a pc-relative offset, don't use
a method that depends on getting a pointer to the newly inserted method.

Use the new nextinstrOffset() method when computing the encoding of the
pc-relative offset, and only insert each instruction once.

Propagate OOM from calls to buffer.allocEntry, folowing the approach in
the ARM assembler.

Comment 3

[Carsten Book [:Tomcat]]

hi, can we get a try run here ?

Comment 4

[Jakob Stoklund Olesen [:jolesen]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5771c7d2e7e1

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f9b612eebb1

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0f9b612eebb1