Closed Bug 1205621 Opened 6 years ago Closed 6 years ago

arm64: propagate OOM from calls to buffer.allocEntry

Categories

(Core :: JavaScript Engine: JIT, defect)

ARM
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: lth, Assigned: jolesen)

References

Details

Attachments

(1 file)

See bug 1186982.  Calls to allocEntry() need to check the result, if the result value is a dummy (unassigned) value then OOM should be signaled via propagateOOM().

On ARM32 there's now one call to allocEntry but ARM64 appears to have several.
This seems like a fine thing for me to work on once I get SM(arm64) into treeherder.
Assignee: nobody → jolesen
When inserting instructions that encode a pc-relative offset, don't use
a method that depends on getting a pointer to the newly inserted method.

Use the new nextinstrOffset() method when computing the encoding of the
pc-relative offset, and only insert each instruction once.

Propagate OOM from calls to buffer.allocEntry, folowing the approach in
the ARM assembler.
Attachment #8665505 - Flags: review?(lhansen)
Attachment #8665505 - Flags: review?(lhansen) → review+
Keywords: checkin-needed
hi, can we get a try run here ?
Flags: needinfo?(jolesen)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0f9b612eebb1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.