1205625 - window deactivate event triggers on going into fullscreen

Status: RESOLVED WORKSFORME

(Firefox :: Untriaged, defect)

Description

[noitidart]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150914185908

Steps to reproduce:

listening for deactivate event on window with: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Events#Window_events

it triggers when going into fullscreen


Actual results:

deactivate event triggers when going into fullscreen


Expected results:

it should not trigger

Comment 1

[noitidart]

I tested on FF41.b09 with this code:

window.addEventListener("deactivate", e=>console.log('deactivate:', e))
window.addEventListener("activate", e=>console.log('activate:', e))

then focused window, then hit f11 to toggle fullscreen. i could not reproduce.

Comment 2

[noitidart]

Attachment: sixtyten screenshot showing proof he's on windows 8.1 on fx 40

@sixtyten from irc #extdev reported this.

he shared this screenshot

Comment 3

[noitidart]

Apparently this is probably an invalid bug, user from irc couldn't reproduce either.

Comment 4

[sixtyten]

I managed to reproduce it in another profile and separately on another machine. This only happens when firefox is maximized from STATE_NORMAL, not from STATE_MAXIMIZED.

Comment 5

[sixtyten]

Oops. I meant to say: It happens when I go into fullscreen from STATE_NORMAL. It doesn't happend when I go into fullscreen from STATE_MAXIMIZED.

Comment 6

[noitidart]

Verified with this code from scratchpad that when you go to fullscreen from STATE_MAXIMIZED or STATE_NORMAL  activate does trigger, but deactivate never triggers for me. So the bug is "activate triggers on fullscreen":

code for scratchpad:

window.addEventListener("deactivate", e=>console.log('deactivate:', e))
window.addEventListener("activate", e=>console.log('activate:', e))
window.fullScreen = true;

Comment 7

[noitidart]

@sixty reports that:

if you attach act/deact listeners to a window. then focus the window. (you obviously get an initial activate message on time of focus) but now if you hit f11 you will get a deactivate then activate. I cant reproduce this part. I tried from both STATE_MAXIMIZED and STATE_NORMAL

Comment 8

[sixtyten]

Firefox 42 now animates going into fullscreen and I cannot reproduce this anymore (FF42 + Win8.1).

Comment 9

[noitidart]

I don't see the animation, but i also cannot reproduce. What animates?

Comment 10

[sixtyten]

Youtube for example. Where the window would previously "jump", the screen now fades to black before showing the fullscreened video. It may be a youtube specific thing but either way I don't get any spurious events anymore, neither with DOM fullscreen nor regular fullscreen.

Comment 11

[Justin [:JW_SoftvisionQA]]

Just to verify; You two can not reproduce. Correct?

Comment 12

[noitidart]

(In reply to Justin - QA from comment #11)
> Just to verify; You two can not reproduce. Correct?

Thanks Justin, thats correct, I could not reproduce. But sixtyten is the main guy on this, I filed for him. @sixtyten, should we invalid this? Or is is it still valid?

Comment 13

[sixtyten]

(In reply to Justin - QA from comment #11)
> Just to verify; You two can not reproduce. Correct?

Correct.

(In reply to noitidart from comment #12)
> @sixtyten, should we invalid this?

Yes.

Comment 14

[Justin [:JW_SoftvisionQA]]

Perfect. I will resolve this bug.