Closed Bug 1205658 Opened 9 years ago Closed 9 years ago

Hello Spinner Blue should match other blue elements in Hello

Categories

(Hello (Loop) :: Client, defect, P2)

defect
Points:
1

Tracking

(firefox43 fixed, firefox44 fixed)

RESOLVED FIXED
mozilla44
Iteration:
44.1 - Oct 5
Tracking Status
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: sevaan, Assigned: Mardak)

References

Details

(Whiteboard: [visual refresh defect][color])

Attachments

(2 files)

The blue colour in the Hello spinner is incorrect and does not match any of the other elements in Hello.

Bug 1194622 has the original spinner. The blue should be: #1baada
Summary: Hello Spinner Blue is incorrect → Hello Spinner Blue should match other blue elements in Hello
Points: --- → 1
Rank: 21
Priority: -- → P2
Whiteboard: [visual refresh defect][color]
Attached patch v1Splinter Review
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #8663533 - Flags: review?(standard8)
Comment on attachment 8663533 [details] [diff] [review]
v1

Review of attachment 8663533 [details] [diff] [review]:
-----------------------------------------------------------------

Looks better, thanks.
Attachment #8663533 - Flags: review?(standard8) → review+
Blocks: 1179193
Iteration: --- → 43.3 - Sep 21
Attachment #8663534 - Flags: ui-review+
https://hg.mozilla.org/integration/fx-team/rev/02852948e7de08e201de94391f85396ee5c40b45
Bug 1205658 - Hello Spinner Blue should match other blue elements in Hello [r=Standard8]
https://hg.mozilla.org/mozilla-central/rev/02852948e7de
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment on attachment 8663533 [details] [diff] [review]
v1

Approval Request Comment
[Feature/regressing bug #]: Hello Visual refresh
[User impact if declined]: Spinner has the wrong colour compared to the rest of Hello
[Describe test coverage new/current, TreeHerder]: n/a svg file change only
[Risks and why]: Low, minor svg file change only
[String/UUID change made/needed]: None
Attachment #8663533 - Flags: approval-mozilla-aurora?
Comment on attachment 8663533 [details] [diff] [review]
v1

This has been on m-c a while. OK to uplift to aurora.
Attachment #8663533 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Iteration: 43.3 - Sep 21 → 44.1 - Oct 5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: