Closed
Bug 1205658
Opened 9 years ago
Closed 9 years ago
Hello Spinner Blue should match other blue elements in Hello
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(firefox43 fixed, firefox44 fixed)
People
(Reporter: sevaan, Assigned: Mardak)
References
Details
(Whiteboard: [visual refresh defect][color])
Attachments
(2 files)
6.71 KB,
patch
|
standard8
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
44.42 KB,
image/png
|
sevaan
:
ui-review+
|
Details |
The blue colour in the Hello spinner is incorrect and does not match any of the other elements in Hello.
Bug 1194622 has the original spinner. The blue should be: #1baada
Reporter | ||
Updated•9 years ago
|
Summary: Hello Spinner Blue is incorrect → Hello Spinner Blue should match other blue elements in Hello
Updated•9 years ago
|
Points: --- → 1
Rank: 21
Priority: -- → P2
Whiteboard: [visual refresh defect][color]
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8663533 [details] [diff] [review]
v1
Review of attachment 8663533 [details] [diff] [review]:
-----------------------------------------------------------------
Looks better, thanks.
Attachment #8663533 -
Flags: review?(standard8) → review+
Reporter | ||
Updated•9 years ago
|
Attachment #8663534 -
Flags: ui-review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/02852948e7de08e201de94391f85396ee5c40b45
Bug 1205658 - Hello Spinner Blue should match other blue elements in Hello [r=Standard8]
Comment 5•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment 6•9 years ago
|
||
Comment on attachment 8663533 [details] [diff] [review]
v1
Approval Request Comment
[Feature/regressing bug #]: Hello Visual refresh
[User impact if declined]: Spinner has the wrong colour compared to the rest of Hello
[Describe test coverage new/current, TreeHerder]: n/a svg file change only
[Risks and why]: Low, minor svg file change only
[String/UUID change made/needed]: None
Attachment #8663533 -
Flags: approval-mozilla-aurora?
Comment 7•9 years ago
|
||
Comment on attachment 8663533 [details] [diff] [review]
v1
This has been on m-c a while. OK to uplift to aurora.
Attachment #8663533 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•9 years ago
|
||
status-firefox43:
--- → fixed
Updated•9 years ago
|
Iteration: 43.3 - Sep 21 → 44.1 - Oct 5
You need to log in
before you can comment on or make changes to this bug.
Description
•