1205674 - Remove decompress_if_needed() once uncompressed artifacts expired

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

It was added to handle that legacy artifacts in the DB would not be compressed, since they were ingested prior to us adding (and then fixing) the blob compression.

I'm pretty sure they all should have expired by now, so we should remove it to improve our test coverage (with it in place, we could regress and not realise).

https://github.com/mozilla/treeherder/search?q=decompress_if_needed

Comment 1

[MikeLing]

Attachment: PR for bug 1205674

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8673086 [details] [review]
PR for bug 1205674

Looks good - have left a comment - reflag for review (on the same attachment here) when the PR is updated and I'll take a final look/merge for you. Thanks! :-)

Comment 3

[MikeLing]

Comment on attachment 8673086 [details] [review]
PR for bug 1205674

Hey emorley, I just address the PR as you told me and tests it. Thank you for your advice :)

BTW, I would like to know more about the background of treeherder like how django works for treeherder and how we use vagrant and other tools in tree. Could you tell me some related bugs which need someone to work with? I'll great appreciate for that!

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 8673086 [details] [review]
PR for bug 1205674

Looks good, thank you :-)

Comment 5

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/dbbc101cd07b95752813178115f711a846de4ec8
Bug 1205674 - Remove decompress_if_needed()

https://github.com/mozilla/treeherder/commit/52b6b8bc45809e409cc6eaca7aab53e434c7ccc2
Merge pull request #1060 from MikeLing/bugfix-1205674

Bug 1205674 - Remove decompress_if_needed()

Comment 6

[Ed Morley [:emorley]]

(In reply to MikeLing from comment #3)
> BTW, I would like to know more about the background of treeherder like how
> django works for treeherder and how we use vagrant and other tools in tree.
> Could you tell me some related bugs which need someone to work with? I'll
> great appreciate for that!

That's quite a big question - maybe easier to chat about it with my/the others in #treeherder some time? :-)

Thank you for the PR here!