1205677 - Set --toolbarbutton-checkedhover-backgroundcolor to something reasonable for Windows 8 and 10

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P4)

Description

[Dão Gottwald [:dao]]

From bug 1205234:

> This is the same as toolbarbutton-active-background, which is the background
> the icon gets without hover (for [checked] toolbarbuttons), so right now this
> doesn't do anything on win8

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Also fixed Linux while I was there

Comment 2

[:Gijs (out for now; he/him)]

Comment on attachment 8665947 [details] [diff] [review]
patch

Review of attachment 8665947 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but see below.

::: browser/themes/linux/browser.css
@@ +28,5 @@
>    --toolbarbutton-active-boxshadow: 0 1px 1px hsla(0,0%,0%,.1) inset, 0 0 1px hsla(0,0%,0%,.3) inset;
>    --toolbarbutton-active-bordercolor: rgb(154,154,154);
>    --toolbarbutton-active-background: rgba(154,154,154,.5) linear-gradient(hsla(0,0%,100%,.7), hsla(0,0%,100%,.4));
>  
> +  --toolbarbutton-checkedhover-backgroundcolor: rgba(154,154,154,.15);

I'm assuming this works with both light and dark text/bg toolbars, then?

Comment 3

[Dão Gottwald [:dao]]

> ::: browser/themes/linux/browser.css
> @@ +28,5 @@
> >    --toolbarbutton-active-boxshadow: 0 1px 1px hsla(0,0%,0%,.1) inset, 0 0 1px hsla(0,0%,0%,.3) inset;
> >    --toolbarbutton-active-bordercolor: rgb(154,154,154);
> >    --toolbarbutton-active-background: rgba(154,154,154,.5) linear-gradient(hsla(0,0%,100%,.7), hsla(0,0%,100%,.4));
> >  
> > +  --toolbarbutton-checkedhover-backgroundcolor: rgba(154,154,154,.15);
> 
> I'm assuming this works with both light and dark text/bg toolbars, then?

yep

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8676dd9dde5f

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8676dd9dde5f

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8665947 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: not a recent regression, but would be nice to have this in the same release as bug 1173743
[User impact if declined]: checked toolbar buttons might look weird or lack feedback on hover
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: very low, just setting the --toolbarbutton-checkedhover-backgroundcolor CSS variable to more sensible values
[String/UUID change made/needed]:

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8665947 [details] [diff] [review]
patch

Minor css fix, ok to uplift to aurora.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/28ddc15188e4