Set --toolbarbutton-checkedhover-backgroundcolor to something reasonable for Windows 8 and 10

RESOLVED FIXED in Firefox 43

Status

()

defect
P4
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks 1 bug)

Trunk
Firefox 44
All
Windows 10
Points:
---

Firefox Tracking Flags

(firefox43 fixed, firefox44 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
From bug 1205234:

> This is the same as toolbarbutton-active-background, which is the background
> the icon gets without hover (for [checked] toolbarbuttons), so right now this
> doesn't do anything on win8
(Assignee)

Updated

4 years ago
Priority: -- → P4
(Assignee)

Comment 1

4 years ago
Posted patch patchSplinter Review
Also fixed Linux while I was there
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #8665947 - Flags: review?(gijskruitbosch+bugs)

Comment 2

4 years ago
Comment on attachment 8665947 [details] [diff] [review]
patch

Review of attachment 8665947 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but see below.

::: browser/themes/linux/browser.css
@@ +28,5 @@
>    --toolbarbutton-active-boxshadow: 0 1px 1px hsla(0,0%,0%,.1) inset, 0 0 1px hsla(0,0%,0%,.3) inset;
>    --toolbarbutton-active-bordercolor: rgb(154,154,154);
>    --toolbarbutton-active-background: rgba(154,154,154,.5) linear-gradient(hsla(0,0%,100%,.7), hsla(0,0%,100%,.4));
>  
> +  --toolbarbutton-checkedhover-backgroundcolor: rgba(154,154,154,.15);

I'm assuming this works with both light and dark text/bg toolbars, then?
Attachment #8665947 - Flags: review?(gijskruitbosch+bugs) → review+
(Assignee)

Comment 3

4 years ago
> ::: browser/themes/linux/browser.css
> @@ +28,5 @@
> >    --toolbarbutton-active-boxshadow: 0 1px 1px hsla(0,0%,0%,.1) inset, 0 0 1px hsla(0,0%,0%,.3) inset;
> >    --toolbarbutton-active-bordercolor: rgb(154,154,154);
> >    --toolbarbutton-active-background: rgba(154,154,154,.5) linear-gradient(hsla(0,0%,100%,.7), hsla(0,0%,100%,.4));
> >  
> > +  --toolbarbutton-checkedhover-backgroundcolor: rgba(154,154,154,.15);
> 
> I'm assuming this works with both light and dark text/bg toolbars, then?

yep
https://hg.mozilla.org/mozilla-central/rev/8676dd9dde5f
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
(Assignee)

Comment 6

4 years ago
Comment on attachment 8665947 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: not a recent regression, but would be nice to have this in the same release as bug 1173743
[User impact if declined]: checked toolbar buttons might look weird or lack feedback on hover
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: very low, just setting the --toolbarbutton-checkedhover-backgroundcolor CSS variable to more sensible values
[String/UUID change made/needed]:
Attachment #8665947 - Flags: approval-mozilla-aurora?
Comment on attachment 8665947 [details] [diff] [review]
patch

Minor css fix, ok to uplift to aurora.
Attachment #8665947 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.