1205763 - test_gallery_handle_valid_image_file.py : TimeoutException: TimeoutException: Timed out after 30.1 seconds

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Max Ivanov[:MaxIvanov]]

Description: Test case fails with an "TimeoutException" error with GIF, JPG, PNG, JPG progressive and PNG transparent images.

Steps:
1. Update a flame device to 20150917030226
2. http://lxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_handle_valid_image_file.py

Actual result:
"TimeoutException" error

Expected result:
Test completes successfully.

From this report: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2/423/HTML_Report/

Traceback (most recent call last):
File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2/.env/local/lib/python2.7/site-packages/marionette_client-0.17-py2.7.egg/marionette/marionette_test.py", line 296, in run
testMethod()
File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2/.env/local/lib/python2.7/site-packages/marionette_client-0.17-py2.7.egg/marionette/marionette_test.py", line 174, in wrapper
return func(self, *args, **kwargs)
File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_handle_valid_image_file.py", line 50, in test_gallery_open_valid_image_file
Wait(self.marionette).until(lambda m: image.current_image_size_width == 2 * initial_width)
File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2/.env/local/lib/python2.7/site-packages/marionette_driver-0.13-py2.7.egg/marionette_driver/wait.py", line 143, in until
cause=last_exc)
TimeoutException: TimeoutException: Timed out after 30.1 seconds

Comment 1

[Martijn Wargers (dead)]

Attachment: (PNG Image, 854 × 480 pixels).png

It looks like the image preview is suddenly in landcape mode. I thought they used to be always in portrait mode, right?

Comment 2

[Martijn Wargers (dead)]

I just noticed that if I hold the phone horizontally, I get the same failures as in this bug.
Why don't we have a pref that locks the orientation to portrait or are we guaranteed to have the devices in an upward position?

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1205763 > mozilla-b2g:master

Comment 4

[Martijn Wargers (dead)]

Comment on attachment 8663187 [details] [review]
[gaia] mwargers:1205763 > mozilla-b2g:master

This fixes it. Of course, there is also something to say for the argument that the device should only be tested in portrait position.

Comment 5

[Martijn Wargers (dead)]

I first tried to use change_orientation, but that only seemed to work for a very short while or not at all. It seemed buggy to me.

Comment 6

[No-Jun Park [:njpark]]

Comment on attachment 8663187 [details] [review]
[gaia] mwargers:1205763 > mozilla-b2g:master

Hmm, you're right, depending on the image size, this would only work on portrait mode. I think the fix is good though.

Comment 7

[Martijn Wargers (dead)]

Merged: https://github.com/mozilla-b2g/gaia/commit/f555098fb5e97ed2103ef8725b1074b22526286b