Coverity 1323784 indicates a useless passed-by-value argument in nsEditorSpellCheck::TryDictionary

RESOLVED FIXED in Firefox 44

Status

()

Firefox
Untriaged
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: Calixte Denizet, Assigned: Calixte Denizet)

Tracking

(Blocks: 1 bug, {coverity})

43 Branch
Firefox 44
coverity
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

(Whiteboard: [CID 1323784])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

3 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20150917192208

Steps to reproduce:

Coverity indicates that the first argument aDictName [1] could be passed by reference.

[1] https://dxr.mozilla.org/mozilla-central/source/editor/composer/nsEditorSpellCheck.cpp#743
Keywords: coverity
Whiteboard: [CID 1323784]
Assignee: nobody → calixte.denizet
(Assignee)

Updated

3 years ago
Attachment #8662567 - Flags: review?(bugs)

Comment 2

3 years ago
Comment on attachment 8662567 [details] [diff] [review]
bug1205796.patch

Oops, I missed this while reviewing.
The param should be
const nsAString& aDictName
with that, r+
Attachment #8662567 - Flags: review?(bugs) → review+
(Assignee)

Comment 3

3 years ago
Created attachment 8664095 [details] [diff] [review]
bug1205796_2.patch
(Assignee)

Comment 4

3 years ago
Comment on attachment 8664095 [details] [diff] [review]
bug1205796_2.patch

Review of attachment 8664095 [details] [diff] [review]:
-----------------------------------------------------------------

carrying r+ from Olli
Attachment #8664095 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Updated

3 years ago
Attachment #8662567 - Attachment is obsolete: true
(Assignee)

Comment 6

3 years ago
Created attachment 8664110 [details] [diff] [review]
bug1205796_3.patch

carrying r+ from Olli
Attachment #8664110 - Flags: review+
(Assignee)

Updated

3 years ago
Attachment #8664095 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8664095 - Attachment is obsolete: false
(Assignee)

Updated

3 years ago
Attachment #8664110 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/5edc7a3188ee
Status: UNCONFIRMED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in before you can comment on or make changes to this bug.