Closed Bug 1205796 Opened 5 years ago Closed 5 years ago

Coverity 1323784 indicates a useless passed-by-value argument in nsEditorSpellCheck::TryDictionary

Categories

(Firefox :: Untriaged, defect)

43 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: calixte.denizet, Assigned: calixte.denizet)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [CID 1323784])

Attachments

(1 file, 2 obsolete files)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20150917192208

Steps to reproduce:

Coverity indicates that the first argument aDictName [1] could be passed by reference.

[1] https://dxr.mozilla.org/mozilla-central/source/editor/composer/nsEditorSpellCheck.cpp#743
Attached patch bug1205796.patch (obsolete) — Splinter Review
Keywords: coverity
Whiteboard: [CID 1323784]
Assignee: nobody → calixte.denizet
Attachment #8662567 - Flags: review?(bugs)
Comment on attachment 8662567 [details] [diff] [review]
bug1205796.patch

Oops, I missed this while reviewing.
The param should be
const nsAString& aDictName
with that, r+
Attachment #8662567 - Flags: review?(bugs) → review+
Comment on attachment 8664095 [details] [diff] [review]
bug1205796_2.patch

Review of attachment 8664095 [details] [diff] [review]:
-----------------------------------------------------------------

carrying r+ from Olli
Attachment #8664095 - Flags: review+
Keywords: checkin-needed
Attachment #8662567 - Attachment is obsolete: true
Attached patch bug1205796_3.patch (obsolete) — Splinter Review
carrying r+ from Olli
Attachment #8664110 - Flags: review+
Attachment #8664095 - Attachment is obsolete: true
Attachment #8664095 - Attachment is obsolete: false
Attachment #8664110 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/5edc7a3188ee
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in before you can comment on or make changes to this bug.