Closed
Bug 1205803
Opened 9 years ago
Closed 9 years ago
Use a separate tableName for Clear Private Data strings
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bnicholson, Assigned: bnicholson)
Details
Attachments
(1 file)
Should prevent strings from being collapsed (see https://bugzilla.mozilla.org/show_bug.cgi?id=1201642#c10).
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8662553 -
Flags: review?(sarentz)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8662553 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1082
LGTM
Attachment #8662553 -
Flags: review?(sarentz) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•9 years ago
|
||
So, just to be clear, there are 3 Clear Private Data strings:
1) The general-level settings item,
2) The Clear Private Data settings page title, and
3) The Clear Private Data settings page button.
This PR succeeded in separating 1 from 2 & 3, but 2 & 3 are still collapsed into a single item. We could create another tableName specifically for the nav title or the button, though that feels like a hack. I can do this if l10n thinks it'd be worth it.
You need to log in
before you can comment on or make changes to this bug.
Description
•