1205865 - Enable test_mediarecorder_bitrate.html for Android 2.3

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect, P3)

Description

[Maire Reavy [:mreavy]]

+++ This bug was initially created as a clone of Bug #1161276 +++

test_mediarecorder_bitrate.html fails on Android 2.3 (only), even though there's no obvious platform-specific code.  Resolve the problem or determine that it can't be supported.

Comment 1

[Geoff Brown [:gbrown]]

Android 2.3 is no longer supported (Firefox 48+). There's probably nothing to do here.

Comment 2

[Benjamin Chen [:bechen]]

Attachment: MozReview Request: Bug 1205865 - Enable test_mediarecorder_bitrate.html for android. r=jwwang

Review commit: https://reviewboard.mozilla.org/r/48319/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48319/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8744149 [details]
MozReview Request: Bug 1205865 - Enable test_mediarecorder_bitrate.html for android. r=jwwang

https://reviewboard.mozilla.org/r/48319/#review45085

Please add comments to describe something like "This test failed only on Android 2.3. Since we don't support 2.3 anymore, it is safe to enable the test on Android again."

Comment 4

[Benjamin Chen [:bechen]]

https://reviewboard.mozilla.org/r/48319/#review45085

oK, I'll try to add comment if neccessary.
I enable the testcase due to we had support the video encoding on fennec, not because we don't support 2.3.

Comment 5

[Benjamin Chen [:bechen]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9852a21bf245

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7d6853ddf2f

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e7d6853ddf2f

Comment 8

[Eugen Sawin [:esawin]]

Fennec does not have video recording support, see bug 1232308.

On Fennec, neither MOZ_OMX_ENCODER nor MOZ_WEBM_ENCODER are defined or supported (OMX is missing encoding support, WebM has no encoder support for Tremor), so we fallback to audio-only Opus encoding.

There is a plan to enable video encoding via MP4 + Opus, but that's not being worked on currently.

We need to back this out.

Comment 9

[Thomas Daede [:TD-Linux]]

Any reason not to enable MOZ_WEBM_ENCODER and just encode a VP8 + Opus webm? Alternately, it looks like removing S16 support is in progress (bug 1262765) - which would presumably switch us over from tremor to libvorbis.

Comment 10

[Eugen Sawin [:esawin]]

(In reply to Thomas Daede from comment #9)
> Any reason not to enable MOZ_WEBM_ENCODER and just encode a VP8 + Opus webm?
> Alternately, it looks like removing S16 support is in progress (bug 1262765)
> - which would presumably switch us over from tremor to libvorbis.

With bug 1262765 we would be one step closer to enabling this, but further investigation would be required to make it work on Android.

As it is, we can't just flip the switch to enable it.

Comment 11

[Benjamin Chen [:bechen]]

(In reply to Thomas Daede from comment #9)
> Any reason not to enable MOZ_WEBM_ENCODER and just encode a VP8 + Opus webm?

At Bug 1215115, I have already using vp8+opus in webm, that's why I enable the testcase here.
So now the testcase still fail on android?

Comment 12

[Eugen Sawin [:esawin]]

In this case let's investigate what's going wrong in the test in bug 1272877, sorry for the confusion.