Closed Bug 1205941 Opened 6 years ago Closed 6 years ago

Make TimerFirings logging output post-processible with fix_linux_stack.py

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(1 file, 1 obsolete file)

glandium suggested tweaking the output of TimerFirings logging so that the
unannotated functions can be post-processed by fix_linux_stack.py.
Now with less Android bustage on try.
Attachment #8662780 - Flags: review?(mh+mozilla)
Attachment #8662749 - Attachment is obsolete: true
Attachment #8662749 - Flags: review?(mh+mozilla)
Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2846bc53ff05

(Though try server is having a rough time of it lately, with lots of intermittent build failures.)
Comment on attachment 8662780 [details] [diff] [review]
Make TimerFirings logging output post-processible with fix_linux_stack.py

Review of attachment 8662780 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/threads/nsTimerImpl.cpp
@@ +653,3 @@
>          }
>  #else
>          name = "???[dladdr: unavailable/doesn't work on this platform]";

it would be more truthful to say it's unimplemented, and not to mention dladdr, because at this point, you're essentially going to end up changing the ifdef setting USE_DLADDR for BSDs or add support for windows.
Attachment #8662780 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/ab99a70d0586
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Depends on: 1254218
You need to log in before you can comment on or make changes to this bug.