1205941 - Make TimerFirings logging output post-processible with fix_linux_stack.py

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nicholas Nethercote [inactive]]

glandium suggested tweaking the output of TimerFirings logging so that the
unannotated functions can be post-processed by fix_linux_stack.py.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Make TimerFirings logging output post-processible with fix_linux_stack.py

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Make TimerFirings logging output post-processible with fix_linux_stack.py

Now with less Android bustage on try.

Comment 3

[Nicholas Nethercote [inactive]]

Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2846bc53ff05

(Though try server is having a rough time of it lately, with lots of intermittent build failures.)

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8662780 [details] [diff] [review]
Make TimerFirings logging output post-processible with fix_linux_stack.py

Review of attachment 8662780 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/threads/nsTimerImpl.cpp
@@ +653,3 @@
>          }
>  #else
>          name = "???[dladdr: unavailable/doesn't work on this platform]";

it would be more truthful to say it's unimplemented, and not to mention dladdr, because at this point, you're essentially going to end up changing the ifdef setting USE_DLADDR for BSDs or add support for windows.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab99a70d0586

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ab99a70d0586