1205962 - Address some pylint complaints about pycert.py and pykey.py

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[:Cykesiopka]

I recently ran pylint on pycert.py and pykey.py; the default config spends most of its time complaining about the camel case var and function names, but some of the warnings below seemed easy/worth fixing:
 - __init__ method from base class 'Exception' is not called (super-init-not-called)
 - Old-style class defined. (old-style-class)
 - No space allowed around keyword argument assignment
 - Wrong hanging indentation
 - unused-import

This pattern:
> index = 0
> for value in foo:
>     ...
>     index += 1

is also replaced by the shorter:
> for index, value in enumerate(foo):
>     ...

Comment 1

[:Cykesiopka]

Attachment: MozReview Request: Bug 1205962 - Address some pylint complaints about pycert.py and pykey.py.

Bug 1205962 - Address some pylint complaints about pycert.py and pykey.py.

Also adds more uses of enumerate() to simplify code.

Comment 2

[:Cykesiopka]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dfb9a5f3af5e

Comment 3

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Comment on attachment 8670105 [details]
MozReview Request: Bug 1205962 - Address some pylint complaints about pycert.py and pykey.py.

https://reviewboard.mozilla.org/r/21329/#review19271

Awesome - thanks for doing this!

Comment 4

[:Cykesiopka]

Thanks for the review.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec07ca6a4679

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ec07ca6a4679