Closed
Bug 1205962
Opened 10 years ago
Closed 10 years ago
Address some pylint complaints about pycert.py and pykey.py
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: Cykesiopka, Assigned: Cykesiopka)
References
Details
Attachments
(1 file)
I recently ran pylint on pycert.py and pykey.py; the default config spends most of its time complaining about the camel case var and function names, but some of the warnings below seemed easy/worth fixing:
- __init__ method from base class 'Exception' is not called (super-init-not-called)
- Old-style class defined. (old-style-class)
- No space allowed around keyword argument assignment
- Wrong hanging indentation
- unused-import
This pattern:
> index = 0
> for value in foo:
> ...
> index += 1
is also replaced by the shorter:
> for index, value in enumerate(foo):
> ...
![]() |
Assignee | |
Comment 1•10 years ago
|
||
Bug 1205962 - Address some pylint complaints about pycert.py and pykey.py.
Also adds more uses of enumerate() to simplify code.
Attachment #8670105 -
Flags: review?(dkeeler)
![]() |
Assignee | |
Comment 2•10 years ago
|
||
![]() |
||
Comment 3•10 years ago
|
||
Comment on attachment 8670105 [details]
MozReview Request: Bug 1205962 - Address some pylint complaints about pycert.py and pykey.py.
https://reviewboard.mozilla.org/r/21329/#review19271
Awesome - thanks for doing this!
Attachment #8670105 -
Flags: review?(dkeeler) → review+
Keywords: checkin-needed
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•