Closed Bug 1205976 Opened 6 years ago Closed 6 years ago

Improve logging for TelemetryStorage.loadAbortedSessionPing

Categories

(Toolkit :: Telemetry, defect, P1)

defect
Points:
1

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- affected
firefox44 --- fixed

People

(Reporter: gfritzsche, Assigned: Dexter)

References

Details

(Whiteboard: [unifiedTelemetry][measurement:client])

Attachments

(1 file)

loadAbortedSessionPing() logs about failing to remove a ping when it actually failed to read or parse a ping:
https://dxr.mozilla.org/mozilla-central/rev/9ed17db42e3e46f1c712e4dffd62d54e915e0fac/toolkit/components/telemetry/TelemetryStorage.jsm#1540

Additionally Vladan requested we make this log the file path too.
Doesn't the aborted-session ping always have the same path (relative to the profile)?
It does ($profile/datareporting/aborted-session-ping). Vladan, do you really want that part?
Flags: needinfo?(vladan.bugzilla)
Points: --- → 1
Priority: -- → P1
Whiteboard: [unifiedTelemetry] → [unifiedTelemetry][measurement:client]
I'd just like to know which ping Telemetry had a problem with. If it's the aborted session ping, then we can just say it's the aborted ping. 
For other pings, the path relative to the profile directory would be enough.
Flags: needinfo?(vladan.bugzilla)
The path for the other pings is already logged (trace level), see [0]/|TelemetryStorage.loadPingFile). I'll change [1] to a more clear error message ("error loading ping" instead of "error removing ping").

[0] - https://dxr.mozilla.org/mozilla-central/rev/9ed17db42e3e46f1c712e4dffd62d54e915e0fac/toolkit/components/telemetry/TelemetryStorage.jsm?offset=200#1448

[1] - https://dxr.mozilla.org/mozilla-central/rev/9ed17db42e3e46f1c712e4dffd62d54e915e0fac/toolkit/components/telemetry/TelemetryStorage.jsm?offset=200#1540
Attached patch bug1205976.patchSplinter Review
This patch changes the log line to a more appropriate one.
Assignee: nobody → alessio.placitelli
Status: NEW → ASSIGNED
Attachment #8664200 - Flags: review?(gfritzsche)
Attachment #8664200 - Flags: review?(gfritzsche) → review+
https://hg.mozilla.org/integration/fx-team/rev/0f1f7daec31f73372eb11b47157d557a553bc8cf
Bug 1205976 - Improve logging for TelemetryStorage.loadAbortedSessionPing. r=gfritzsche
https://hg.mozilla.org/mozilla-central/rev/0f1f7daec31f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.