1205976 - Improve logging for TelemetryStorage.loadAbortedSessionPing

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Georg Fritzsche [:gfritzsche]]

loadAbortedSessionPing() logs about failing to remove a ping when it actually failed to read or parse a ping:
https://dxr.mozilla.org/mozilla-central/rev/9ed17db42e3e46f1c712e4dffd62d54e915e0fac/toolkit/components/telemetry/TelemetryStorage.jsm#1540

Additionally Vladan requested we make this log the file path too.

Comment 1

[Alessio Placitelli [:Dexter]]

Doesn't the aborted-session ping always have the same path (relative to the profile)?

Comment 2

[Georg Fritzsche [:gfritzsche]]

It does ($profile/datareporting/aborted-session-ping). Vladan, do you really want that part?

Comment 3

[Vladan Djeric (:vladan)]

I'd just like to know which ping Telemetry had a problem with. If it's the aborted session ping, then we can just say it's the aborted ping. 
For other pings, the path relative to the profile directory would be enough.

Comment 4

[Alessio Placitelli [:Dexter]]

The path for the other pings is already logged (trace level), see [0]/|TelemetryStorage.loadPingFile). I'll change [1] to a more clear error message ("error loading ping" instead of "error removing ping").

[0] - https://dxr.mozilla.org/mozilla-central/rev/9ed17db42e3e46f1c712e4dffd62d54e915e0fac/toolkit/components/telemetry/TelemetryStorage.jsm?offset=200#1448

[1] - https://dxr.mozilla.org/mozilla-central/rev/9ed17db42e3e46f1c712e4dffd62d54e915e0fac/toolkit/components/telemetry/TelemetryStorage.jsm?offset=200#1540

Comment 5

[Alessio Placitelli [:Dexter]]

Attachment: bug1205976.patch

This patch changes the log line to a more appropriate one.

Comment 6

[Alessio Placitelli [:Dexter]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=184072ec48ac

Comment 7

[Alessio Placitelli [:Dexter]]

https://hg.mozilla.org/integration/fx-team/rev/0f1f7daec31f73372eb11b47157d557a553bc8cf
Bug 1205976 - Improve logging for TelemetryStorage.loadAbortedSessionPing. r=gfritzsche

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0f1f7daec31f