loadAbortedSessionPing() logs about failing to remove a ping when it actually failed to read or parse a ping: https://dxr.mozilla.org/mozilla-central/rev/9ed17db42e3e46f1c712e4dffd62d54e915e0fac/toolkit/components/telemetry/TelemetryStorage.jsm#1540 Additionally Vladan requested we make this log the file path too.
Doesn't the aborted-session ping always have the same path (relative to the profile)?
It does ($profile/datareporting/aborted-session-ping). Vladan, do you really want that part?
Points: --- → 1
Priority: -- → P1
Whiteboard: [unifiedTelemetry] → [unifiedTelemetry][measurement:client]
I'd just like to know which ping Telemetry had a problem with. If it's the aborted session ping, then we can just say it's the aborted ping. For other pings, the path relative to the profile directory would be enough.
The path for the other pings is already logged (trace level), see /|TelemetryStorage.loadPingFile). I'll change  to a more clear error message ("error loading ping" instead of "error removing ping").  - https://dxr.mozilla.org/mozilla-central/rev/9ed17db42e3e46f1c712e4dffd62d54e915e0fac/toolkit/components/telemetry/TelemetryStorage.jsm?offset=200#1448  - https://dxr.mozilla.org/mozilla-central/rev/9ed17db42e3e46f1c712e4dffd62d54e915e0fac/toolkit/components/telemetry/TelemetryStorage.jsm?offset=200#1540
Created attachment 8664200 [details] [diff] [review] bug1205976.patch This patch changes the log line to a more appropriate one.
Assignee: nobody → alessio.placitelli
Status: NEW → ASSIGNED
Attachment #8664200 - Flags: review?(gfritzsche)
Attachment #8664200 - Flags: review?(gfritzsche) → review+
https://hg.mozilla.org/integration/fx-team/rev/0f1f7daec31f73372eb11b47157d557a553bc8cf Bug 1205976 - Improve logging for TelemetryStorage.loadAbortedSessionPing. r=gfritzsche
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.