1206040 - [Music][NGA] Error page "Unplug the phone to play music" is not shown when device is connected to a PC.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, enhancement, P1)

Description

[Autumn.Qiu(Leave from Mozilla)]

Attachment: logcat_Flame_v2.5.txt

[1.Description]:
[Flame v2.5][Music NGA]When the device is connected to a PC with a USB cable, launch the Messaging app. Taping the new message icon, then tap the attachment icon and select Music NGA, it will switch to Music NGA library.
See attachment: logcat_Flame_v2.5.txt & Flame_v2.5.3gp
Found time: 16:44

[2.Testing Steps]: 
Prerequisite: USB sharing is on and the device is connected to a PC with a USB cable 

1. Launch the Messaging app. 
2. Tap the new message icon. 
3. Tap the attachment icon then select Music NGA. 


[3.Expected Result]: 
In step 3,  "Unplug the phone to play music"" error page should appear. 

[4.Actual Result]: 
In step 3, it will switch to Music NGA library.

[5.Reproduction build]: 
Flame KK v2.5(Affected)
Build ID               20150917150223
Gaia Revision          aede8622d780ec71f766a3ecccbff74c04aaba4e
Gaia Date              2015-09-17 03:40:46
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3929b8fc6c33bf9cc80299743063f0981f545452
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150917.183330
Firmware Date          Thu Sep 17 18:33:40 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
13270

Comment 1

[Autumn.Qiu(Leave from Mozilla)]

Attachment: Flame_v2.5.3gp

Comment 2

[Hema Koka [:hema]]

This case needs implementation, assigning to Justin. 

Thanks
Hema

Comment 3

[Justin D'Arcangelo [:justindarc]]

D'oh!! This is an amateur mistake.. The "overlay" is a web component and the picker activity's .html file is not including it :-/

Patch is on the way!

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] justindarc:bug1206040 > mozilla-b2g:master

Comment 5

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8663060 [details] [review]
[gaia] justindarc:bug1206040 > mozilla-b2g:master

Forgot to add the r? on this one.

Comment 6

[Jim Porter (:squib)]

Comment on attachment 8663060 [details] [review]
[gaia] justindarc:bug1206040 > mozilla-b2g:master

Looks good to me!

Comment 7

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/d03042db7cec2afe6bf6fe1b42300393bdb6a94f

Comment 8

[Norry.L.F(Leave from Mozilla)]

Hi Autumn,

Please verify this bug, thanks.

Comment 9

[Autumn.Qiu(Leave from Mozilla)]

This bug has been verified as "pass" on the latest engineer build of Flame KK v2.5 by the STR in comment 0.

Actual results: Tap the attachment icon then select Music NGA, "Unplug the phone to play music" error page appears.

See attachment: Verified_FlameKK_v2.5_USB.3gp
Reproduce rate: 0/10

Device: Flame KK 2.5 Eng(Pass)
Build ID               20150923150203
Gaia Revision          8472f0c736660072799aaae60e4b6001a6aaceb4
Gaia Date              2015-09-23 10:29:02
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4a46de29431baa621d98d8f1168e43297ce1a916
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150923.184655
Firmware Date          Wed Sep 23 18:47:17 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 10

[Autumn.Qiu(Leave from Mozilla)]

Attachment: Verified_FlameKK_v2.5_USB.3gp