1206055 - No feedback notification is displayed after tapping a link with "Open multiple links" pref enabled on Gingerbread

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Device: HTC Desire HD (Android 2.3.5)
Steps to reproduce:
1. Check "Open multiple links" in Settings
2. Go to twitter and tap on a link
3. Choose Aurora/Nightly from "Complete action using" dialog

Expected results:
- "Tab saved in Firefox| Open now" notification is displayed

Actual results:
- No notification is displayed.
- Tab is put in tab queue in the android notification bar
- please take a look at the video: https://www.youtube.com/watch?v=RUXR40YIqvI&feature=youtu.be

Comment 1

[:Margaret Leibovic]

Martyn, do you have a device where you can reproduce this?

Comment 2

[Richard Newman [:rnewman]]

Triage consensus is to disable Tab Queues on Gingerbread rather than working on fixing these button toasts on GB.

Comment 3

[Martyn Haigh (:mhaigh)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd38fad87841

Comment 4

[Martyn Haigh (:mhaigh)]

Attachment: MozReview Request: Bug 1206055 - No feedback notification is displayed after tapping a link with "Open multiple links" pref enabled on Gingerbread; r?mcomella

Bug 1206055 - No feedback notification is displayed after tapping a link with "Open multiple links" pref enabled on Gingerbread; r?mcomella

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Richard Newman [:rnewman] from comment #2)
> Triage consensus is to disable Tab Queues on Gingerbread rather than working
> on fixing these button toasts on GB.

Seems like we'd get this for free with snackbars (bug 1157526).

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

What is the reason for disabling tab queues on GB? Was this the same discussion about providing a more feature-limited product on GB so it's faster and less buggy (because we spend less time fixing the bugs specific to this platform)?

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8666074 [details]
MozReview Request: Bug 1206055 - No feedback notification is displayed after tapping a link with "Open multiple links" pref enabled on Gingerbread; r?mcomella

https://reviewboard.mozilla.org/r/20431/#review18513

I'm sad that we need all of these different entry points (i.e. branches) to enable/disable tab queues. It'd be great if we could have a centralized method for enabling/disabling features (/me adds frontend team meeting note).

Comment 8

[Martyn Haigh (:mhaigh)]

Good call, mcomella - the idea of having one entry point for all feature flags is a great plan.

Comment 9

[Martyn Haigh (:mhaigh)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bac73f731f62

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/bac73f731f62

Comment 11

[:Margaret Leibovic]

Martyn, could you request uplift for this?

Comment 12

[Martyn Haigh (:mhaigh)]

Comment on attachment 8666074 [details]
MozReview Request: Bug 1206055 - No feedback notification is displayed after tapping a link with "Open multiple links" pref enabled on Gingerbread; r?mcomella

Approval Request Comment
[Feature/regressing bug #]: 1112185
[User impact if declined]: Gingerbread Users will not see the tab queue notification, making use of the browser frustrating
[Describe test coverage new/current, TreeHerder]: try
[Risks and why]: We touch a few areas of the code here, but only to add a flag - the risk is pretty low overall.  The only thing which may happen is that the feature gets turned on or off for the wrong target audience.
[String/UUID change made/needed]: N/A

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Can you request uplift to beta as well, if you are sure it is affected?

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8666074 [details]
MozReview Request: Bug 1206055 - No feedback notification is displayed after tapping a link with "Open multiple links" pref enabled on Gingerbread; r?mcomella

Looks good for uplift to aurora.

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a29ec46942a5

Comment 16

[:Margaret Leibovic]

Comment on attachment 8666074 [details]
MozReview Request: Bug 1206055 - No feedback notification is displayed after tapping a link with "Open multiple links" pref enabled on Gingerbread; r?mcomella

See comment 12.

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8666074 [details]
MozReview Request: Bug 1206055 - No feedback notification is displayed after tapping a link with "Open multiple links" pref enabled on Gingerbread; r?mcomella

Fix a new feature on some arch, taking it. Thanks!

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/da7436091242

Comment 19

[u421692]

Verified as fixed on latest Nightly and Aurora, and Firefox 42 Beta 6.
"Open multiple links" is disabled, and not displayed