No feedback notification is displayed after tapping a link with "Open multiple links" pref enabled on Gingerbread

VERIFIED FIXED in Firefox 42

Status

()

Firefox for Android
General
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: TeoVermesan, Assigned: mhaigh, NeedInfo)

Tracking

Trunk
Firefox 44
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 verified, firefox43 verified, firefox44 verified, fennec42+)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Tested with:
Device: HTC Desire HD (Android 2.3.5)
Steps to reproduce:
1. Check "Open multiple links" in Settings
2. Go to twitter and tap on a link
3. Choose Aurora/Nightly from "Complete action using" dialog

Expected results:
- "Tab saved in Firefox| Open now" notification is displayed

Actual results:
- No notification is displayed.
- Tab is put in tab queue in the android notification bar
- please take a look at the video: https://www.youtube.com/watch?v=RUXR40YIqvI&feature=youtu.be
(Reporter)

Updated

2 years ago
Blocks: 1112185
tracking-fennec: --- → ?
status-firefox42: --- → affected

Comment 1

2 years ago
Martyn, do you have a device where you can reproduce this?
Flags: needinfo?(mhaigh)
Triage consensus is to disable Tab Queues on Gingerbread rather than working on fixing these button toasts on GB.
Assignee: nobody → mhaigh
Status: NEW → ASSIGNED
tracking-fennec: ? → 42+
(Assignee)

Comment 3

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd38fad87841
(Assignee)

Comment 4

2 years ago
Created attachment 8666074 [details]
MozReview Request: Bug 1206055 - No feedback notification is displayed after tapping a link with "Open multiple links" pref enabled on Gingerbread; r?mcomella

Bug 1206055 - No feedback notification is displayed after tapping a link with "Open multiple links" pref enabled on Gingerbread; r?mcomella
Attachment #8666074 - Flags: review?(michael.l.comella)
(In reply to Richard Newman [:rnewman] from comment #2)
> Triage consensus is to disable Tab Queues on Gingerbread rather than working
> on fixing these button toasts on GB.

Seems like we'd get this for free with snackbars (bug 1157526).
What is the reason for disabling tab queues on GB? Was this the same discussion about providing a more feature-limited product on GB so it's faster and less buggy (because we spend less time fixing the bugs specific to this platform)?
Attachment #8666074 - Flags: review?(michael.l.comella) → review+
Comment on attachment 8666074 [details]
MozReview Request: Bug 1206055 - No feedback notification is displayed after tapping a link with "Open multiple links" pref enabled on Gingerbread; r?mcomella

https://reviewboard.mozilla.org/r/20431/#review18513

I'm sad that we need all of these different entry points (i.e. branches) to enable/disable tab queues. It'd be great if we could have a centralized method for enabling/disabling features (/me adds frontend team meeting note).
(Assignee)

Comment 8

2 years ago
Good call, mcomella - the idea of having one entry point for all feature flags is a great plan.
Flags: needinfo?(mhaigh)
(Assignee)

Comment 9

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bac73f731f62
https://hg.mozilla.org/mozilla-central/rev/bac73f731f62
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
(Reporter)

Updated

2 years ago
Depends on: 1211362

Comment 11

2 years ago
Martyn, could you request uplift for this?
Flags: needinfo?(mhaigh)
(Assignee)

Comment 12

2 years ago
Comment on attachment 8666074 [details]
MozReview Request: Bug 1206055 - No feedback notification is displayed after tapping a link with "Open multiple links" pref enabled on Gingerbread; r?mcomella

Approval Request Comment
[Feature/regressing bug #]: 1112185
[User impact if declined]: Gingerbread Users will not see the tab queue notification, making use of the browser frustrating
[Describe test coverage new/current, TreeHerder]: try
[Risks and why]: We touch a few areas of the code here, but only to add a flag - the risk is pretty low overall.  The only thing which may happen is that the feature gets turned on or off for the wrong target audience.
[String/UUID change made/needed]: N/A
Flags: needinfo?(mhaigh)
Attachment #8666074 - Flags: approval-mozilla-aurora?
Can you request uplift to beta as well, if you are sure it is affected?
Flags: needinfo?(mhaigh)
Comment on attachment 8666074 [details]
MozReview Request: Bug 1206055 - No feedback notification is displayed after tapping a link with "Open multiple links" pref enabled on Gingerbread; r?mcomella

Looks good for uplift to aurora.
Attachment #8666074 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/a29ec46942a5
status-firefox43: affected → fixed

Comment 16

2 years ago
Comment on attachment 8666074 [details]
MozReview Request: Bug 1206055 - No feedback notification is displayed after tapping a link with "Open multiple links" pref enabled on Gingerbread; r?mcomella

See comment 12.
Attachment #8666074 - Flags: approval-mozilla-beta?
Comment on attachment 8666074 [details]
MozReview Request: Bug 1206055 - No feedback notification is displayed after tapping a link with "Open multiple links" pref enabled on Gingerbread; r?mcomella

Fix a new feature on some arch, taking it. Thanks!
Attachment #8666074 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/da7436091242
status-firefox42: affected → fixed

Comment 19

2 years ago
Verified as fixed on latest Nightly and Aurora, and Firefox 42 Beta 6.
"Open multiple links" is disabled, and not displayed
Status: RESOLVED → VERIFIED
status-firefox42: fixed → verified
status-firefox43: fixed → verified
status-firefox44: fixed → verified
You need to log in before you can comment on or make changes to this bug.