Closed Bug 1206084 Opened 9 years ago Closed 9 years ago

nsCORSListenerProxy::AsyncOnChannelRedirect() does not cancel original channel if RemoveCorsPreflightCacheEntry() fails

Categories

(Core :: Networking: HTTP, defect)

Product:
Core
Component:
Networking: HTTP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: bkelly, Assigned: bkelly)

References

Details

Attachments

(1 file)

Always Cancel() channel in nsCORSListenerProxy for failed redirects. r=ehsan
1.27 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
See:

  https://dxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsCORSListenerProxy.cpp#757

I fixed a similar problem in OnStartRequest(), but didn't realize the same pattern occurred here.
Blocks: 1199049
No longer depends on: 1199049
Attachment #8662938 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/504162ed4ed4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: