Closed Bug 1206102 Opened 7 years ago Closed 7 years ago

Make the TP list names more flexible from a l10n standpoint


(Firefox :: Preferences, defect, P1)




Firefox 43
43.3 - Sep 21
Tracking Status
firefox43 --- fixed


(Reporter: past, Assigned: past)



(Whiteboard: [fxprivacy])


(1 file, 1 obsolete file)

Bug 1177085 introduced a block list dialog that presents some UI challenges for localizers, due to the length of the strings. Paolo suggested that we could split the strings now, so that future improvements to the text layout could be independent of the localization efforts (hence easy to uplift).
Attached patch Patch v1 (obsolete) — Splinter Review
Paolo, is this what you had in mind?
Attachment #8662953 - Flags: review?(paolo.mozmail)
Comment on attachment 8662953 [details] [diff] [review]
Patch v1

Francesco, are we correct in understanding that splitting the name in two before the uplift will be beneficial to localizers in case we find a nice way to format the text later?
Attachment #8662953 - Flags: feedback?(francesco.lodolo)
Comment on attachment 8662953 [details] [diff] [review]
Patch v1

Review of attachment 8662953 [details] [diff] [review]:

Yes, it would definitely help. In that case we could fix the JS in mozilla-aurora and leave mozNameTemplate unused until it can be removed in mozilla-central.

::: browser/locales/en-US/chrome/browser/preferences/
@@ +41,2 @@
>  # LOCALIZATION NOTE (mozstdName, etc.): These labels appear in the tracking
>  # protection block lists dialog. They are the names of the block lists.

I'd be more explicit with the comment, just to avoid people trying to change the structure of the sentences.

# LOCALIZATION NOTE (mozstdName, etc.): These labels appear in the tracking
# protection block lists dialog, mozNameTemplate is used to create the final
# string. Note that in the future these two strings (name, desc) could be
# displayed on two different lines.
Attachment #8662953 - Flags: feedback?(francesco.lodolo) → feedback+
Attached patch Patch v2Splinter Review
Thanks, I've made the suggested comment change.
Attachment #8662953 - Attachment is obsolete: true
Attachment #8662953 - Flags: review?(paolo.mozmail)
Attachment #8662971 - Flags: review?(paolo.mozmail)
Comment on attachment 8662971 [details] [diff] [review]
Patch v2

Review of attachment 8662971 [details] [diff] [review]:

Yeah, this is what I had in mind for the localization.

I guess I'd simplify some of the code but it's not a big deal, feel free to land as is with the strings for now, we can always iterate later.
Attachment #8662971 - Flags: review?(paolo.mozmail) → review+
Iteration: --- → 43.3 - Sep 21
Flags: qe-verify?
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
No need for QA here.
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.