1206122 - Implement Switch To Parent Frame command

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

Marionette is missing the Switch To Parent Frame command that WebDriver specifies.

Instead Marionette currently lets you switch to the parent frame by the same mechanism that Selenium has, which is to pass an empty string to switchToFrame.

We can probably leave this behaviour there for the time being, until we’ve moved existing tests and client bindings over to this new command.

This was originally reported by Alexei Barancev in https://github.com/jgraham/wires/issues/22.

Comment 1

[Andreas Tolfsen ❲:ato❳]

I was wrong in the description.  Passing an empty string to Switch To Frame will switch to the top-most frame, and not the parent frame.

This, then, is about implementing Switch To Parent Frame as defined in the specification: https://w3c.github.io/webdriver/webdriver-spec.html#switch-to-parent-frame

Comment 2

[David Burns :automatedtester]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4185f316af07

Comment 3

[David Burns :automatedtester]

Attachment: MozReview Request: Bug 1206122: Add support for switchToParentFrame r?jgriffin

Bug 1206122: Add support for switchToParentFrame r?jgriffin

This allows us from a child frame to go up one level. This is documented
at http://w3c.github.io/webdriver/webdriver-spec.html#switch-to-parent-frame

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8675889 [details]
MozReview Request: Bug 1206122: Add support for switchToParentFrame r?jgriffin

https://reviewboard.mozilla.org/r/22489/#review20167

lgtm

Comment 5

[David Burns :automatedtester]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fa277d3857e280f1e82e012afc587ce428feb532
Bug 1206122: Add support for switchToParentFrame r=jgriffin

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fa277d3857e2