1206146 - Use channel->AsyncOpen2() in embedding/components/webbrowserpersist/nsWebBrowserPersist.cpp

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1206146_nswebbrowserpresist.patch

Let's have a look at the callsites of AsyncOpen2() for that patch:
> nsWebBrowserPersist::StartUpload
We call CreateChannelFromURI() which uses the systemPrincipal and call asyncOpen2 right after. That callsite is fine.

> SaveChannelInternal; is called from two places:
(1) nsWebBrowserPersist::SaveURIInternal which uses the systemPrincipal
(2) nsWebBrowserPersist::SaveChannel which is called from
  (a) nsDownload::Resume() and uses the systemPrincipal
  (b) nsWebBrowser::SaveChannel, but I don't see any callsites to that function in our codebase, so here is the question: should we rather branch on the securitymode() within SaveChannelInternal() or no?

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0783f2174228

Comment 3

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/0783f2174228