Closed Bug 1206146 Opened 9 years ago Closed 9 years ago

Use channel->AsyncOpen2() in embedding/components/webbrowserpersist/nsWebBrowserPersist.cpp

Categories

(Core :: DOM: Security, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: ckerschb, Assigned: ckerschb)

References

Details

Attachments

(1 file)

      No description provided.
Assignee: nobody → mozilla
Blocks: 1182535
Let's have a look at the callsites of AsyncOpen2() for that patch:
> nsWebBrowserPersist::StartUpload
We call CreateChannelFromURI() which uses the systemPrincipal and call asyncOpen2 right after. That callsite is fine.

> SaveChannelInternal; is called from two places:
(1) nsWebBrowserPersist::SaveURIInternal which uses the systemPrincipal
(2) nsWebBrowserPersist::SaveChannel which is called from
  (a) nsDownload::Resume() and uses the systemPrincipal
  (b) nsWebBrowser::SaveChannel, but I don't see any callsites to that function in our codebase, so here is the question: should we rather branch on the securitymode() within SaveChannelInternal() or no?
Attachment #8663041 - Flags: review?(jonas)
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/0783f2174228
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: