1206161 - Readback with SkiaGL canvas on OS X?

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Markus Stange [:mstange]]

With the fix for bug 1206076 applied, scrolling on https://medium.com/art-science/a-warning-for-our-next-great-screenwriters-4af580c2e0b7 (which does drawImage on a canvas for the header image) sometimes seems to cause readback:

mozilla::gfx::DataSourceSurface::Map(mozilla::gfx::DataSourceSurface::MapType, mozilla::gfx::DataSourceSurface::MappedSurface*)
mozilla::gfx::GetCairoSurfaceForSourceSurface(mozilla::gfx::SourceSurface*, bool, mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const&)
mozilla::gfx::DrawTargetCairo::CopySurface(mozilla::gfx::SourceSurface*, mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const&, mozilla::gfx::IntPointTyped<mozilla::gfx::UnknownUnits> const&)
mozilla::layers::CopyableCanvasLayer::UpdateTarget(mozilla::gfx::DrawTarget*)
mozilla::layers::CanvasClient2D::Update(mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits>, mozilla::layers::ClientCanvasLayer*)
ClientCanvasLayer::RenderLayer

mozilla::gfx::DrawTargetCairo::CopySurface(mozilla::gfx::SourceSurface*, mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const&, mozilla::gfx::IntPointTyped<mozilla::gfx::UnknownUnits> const&)
mozilla::layers::CopyableCanvasLayer::UpdateTarget(mozilla::gfx::DrawTarget*)
mozilla::layers::CanvasClient2D::Update(mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits>, mozilla::layers::ClientCanvasLayer*)
ClientCanvasLayer::RenderLayer

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: EnsureTarget before trying to create a layer

We check SkiaGLTex() in this function, which relies on mTarget.

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: EnsureTarget before trying to create a layer v2

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/32fc8e7592b7

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/32fc8e7592b7