Closed Bug 1206165 Opened 6 years ago Closed 6 years ago

crash in mozilla::a11y::DocAccessible::UpdateTreeOnRemoval(mozilla::a11y::Accessible*, nsIContent*)

Categories

(Core :: Disability Access APIs, defect)

43 Branch
Unspecified
Windows NT
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: davidb, Assigned: surkov)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
that should make a trick
Assignee: nobody → surkov.alexander
Attachment #8663287 - Flags: review?(dbolter)
Comment on attachment 8663287 [details] [diff] [review]
patch

Review of attachment 8663287 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/generic/DocAccessible.cpp
@@ +2057,5 @@
>      nsTArray<nsIContent*>* childEls = it.UserData();
>      for (uint32_t idx = 0; idx < childEls->Length(); idx++) {
>        nsIContent* childEl = childEls->ElementAt(idx);
>        Accessible* child = GetAccessible(childEl);
> +      if (child && child->IsInDocument() && !child->GetFrame()) {

OK... was the problem that the child was orphaned?
Attachment #8663287 - Flags: review?(dbolter) → review+
(In reply to David Bolter [:davidb] from comment #2)

> OK... was the problem that the child was orphaned?

that's working assumption
https://hg.mozilla.org/mozilla-central/rev/793589a533f1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
I'm not sure how this bug should end up since I backed out this, bug 1205476, and bug 1133213 on Aurora but not on trunk.
Flags: needinfo?(surkov.alexander)
it should be marked as fixed in Firefox 44
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Flags: needinfo?(surkov.alexander)
Resolution: --- → FIXED
Target Milestone: mozilla43 → mozilla44
This still happens in 44 build 0924, e.g. bp-829c36d3-45cd-4d72-808d-e8d472150924
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Is "status-firefox43: fixed" correct? Seems like it should be "affected", but since I don't know the details around the backout, I'm leaving it alone)
Attached patch patch2Splinter Review
Attachment #8663287 - Attachment is obsolete: true
Attachment #8666885 - Flags: review?(dbolter)
Attachment #8666885 - Flags: review?(dbolter) → review+
https://hg.mozilla.org/mozilla-central/rev/215f91248653
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.