1206165 - crash in mozilla::a11y::DocAccessible::UpdateTreeOnRemoval(mozilla::a11y::Accessible*, nsIContent*)

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

This bug was filed from the Socorro interface and is 
report bp-78ed3630-e310-4854-a5ee-dab402150918.
=============================================================

More here: https://crash-stats.mozilla.com/report/list?product=Firefox&signature=mozilla%3A%3Aa11y%3A%3ADocAccessible%3A%3AUpdateTreeOnRemoval%28mozilla%3A%3Aa11y%3A%3AAccessible%2A%2C+nsIContent%2A%29

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

that should make a trick

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8663287 [details] [diff] [review]
patch

Review of attachment 8663287 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/generic/DocAccessible.cpp
@@ +2057,5 @@
>      nsTArray<nsIContent*>* childEls = it.UserData();
>      for (uint32_t idx = 0; idx < childEls->Length(); idx++) {
>        nsIContent* childEl = childEls->ElementAt(idx);
>        Accessible* child = GetAccessible(childEl);
> +      if (child && child->IsInDocument() && !child->GetFrame()) {

OK... was the problem that the child was orphaned?

Comment 3

[alexander :surkov (:asurkov)]

(In reply to David Bolter [:davidb] from comment #2)

> OK... was the problem that the child was orphaned?

that's working assumption

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/793589a533f1

Comment 5

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/793589a533f1

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backout: 
https://hg.mozilla.org/releases/mozilla-aurora/rev/ecf66181845e

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm not sure how this bug should end up since I backed out this, bug 1205476, and bug 1133213 on Aurora but not on trunk.

Comment 8

[alexander :surkov (:asurkov)]

it should be marked as fixed in Firefox 44

Comment 9

[(Away)]

This still happens in 44 build 0924, e.g. bp-829c36d3-45cd-4d72-808d-e8d472150924

Comment 10

[(Away)]

(Is "status-firefox43: fixed" correct? Seems like it should be "affected", but since I don't know the details around the backout, I'm leaving it alone)

Comment 11

[alexander :surkov (:asurkov)]

Attachment: patch2

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/215f91248653

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/215f91248653