Rename JS_DefaultValue -> JS::ToPrimitive

RESOLVED FIXED in Firefox 44

Status

()

Core
JavaScript Engine
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

Trunk
mozilla44
Points:
---

Firefox Tracking Flags

(firefox43 affected, firefox44 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
As suggested in bug 1054756 comment 22.

I considered replacing this API and JS::GetFirstArgumentAsTypeHint with a single API tailor-made for the sole call site in nsJSNPRuntime.cpp ("DelegateToPrimitive" or something), but decided against it.
(Assignee)

Comment 1

3 years ago
Created attachment 8663031 [details] [diff] [review]
Rename JS_DefaultValue to JS::ToPrimitive
Attachment #8663031 - Flags: review?(jdemooij)
(Assignee)

Updated

3 years ago
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Comment on attachment 8663031 [details] [diff] [review]
Rename JS_DefaultValue to JS::ToPrimitive

Review of attachment 8663031 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8663031 - Flags: review?(jdemooij) → review+
Backed out (along with everything else from that push) for being the likely cause of hazard build bustage: https://treeherder.mozilla.org/logviewer.html#?job_id=14590837&repo=mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/027ddfe2c4af
https://hg.mozilla.org/mozilla-central/rev/45ec4be63961
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.