1206168 - Rename JS_DefaultValue -> JS::ToPrimitive

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

As suggested in bug 1054756 comment 22.

I considered replacing this API and JS::GetFirstArgumentAsTypeHint with a single API tailor-made for the sole call site in nsJSNPRuntime.cpp ("DelegateToPrimitive" or something), but decided against it.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Rename JS_DefaultValue to JS::ToPrimitive

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8663031 [details] [diff] [review]
Rename JS_DefaultValue to JS::ToPrimitive

Review of attachment 8663031 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 3

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba63691a6f79

Comment 4

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2c525883ef7

Comment 5

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e892727a373a884f2ecb09d8c8c9b9a7ceb44d60
Bug 1206168 - Rename JS_DefaultValue to JS::ToPrimitive. r=jandem.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out (along with everything else from that push) for being the likely cause of hazard build bustage: https://treeherder.mozilla.org/logviewer.html#?job_id=14590837&repo=mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/027ddfe2c4af

Comment 7

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/45ec4be639618d9d71bd33b8170f738c3e115151
Bug 1206168 - Rename JS_DefaultValue to JS::ToPrimitive. r=jandem.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/45ec4be63961