Closed Bug 1206168 Opened 4 years ago Closed 4 years ago

Rename JS_DefaultValue -> JS::ToPrimitive

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- affected
firefox44 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(1 file)

As suggested in bug 1054756 comment 22.

I considered replacing this API and JS::GetFirstArgumentAsTypeHint with a single API tailor-made for the sole call site in nsJSNPRuntime.cpp ("DelegateToPrimitive" or something), but decided against it.
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Comment on attachment 8663031 [details] [diff] [review]
Rename JS_DefaultValue to JS::ToPrimitive

Review of attachment 8663031 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8663031 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/45ec4be63961
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.