Remove AUDIO_STREAM_FM after KK

RESOLVED FIXED in Firefox 44

Status

Firefox OS
AudioChannel
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
FxOS-S8 (02Oct)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
AUDIO_STREAM_FM does not exit on aosp android. It was added to caf code. But even on caf, AUDIO_STREAM_FM does not exist anymore. FM radio uses AUDIO_STREAM_MUSIC on flame-kk's code.

It is better to undef AUDIO_STREAM_FM after KK.
(Assignee)

Updated

2 years ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Comment 1

2 years ago
FYI: diagram of FMRadioService
https://github.com/sotaroikeda/firefox-diagrams/blob/master/dom/dom_media_FMRadioService_FirefoxOS_2_5.pdf
(Assignee)

Comment 2

2 years ago
Created attachment 8663123 [details] [diff] [review]
patch - Remove AUDIO_STREAM_FM after KK
(Assignee)

Updated

2 years ago
Attachment #8663123 - Flags: review?(alwu)
Comment on attachment 8663123 [details] [diff] [review]
patch - Remove AUDIO_STREAM_FM after KK

Review of attachment 8663123 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thank!
Attachment #8663123 - Flags: review?(alwu) → review+
(Assignee)

Comment 4

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=79bb412bd374

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5f8280b630f
https://hg.mozilla.org/mozilla-central/rev/d5f8280b630f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S8 (02Oct)
You need to log in before you can comment on or make changes to this bug.