Closed
Bug 1206212
Opened 9 years ago
Closed 9 years ago
Remove AUDIO_STREAM_FM after KK
Categories
(Firefox OS Graveyard :: AudioChannel, defect)
Tracking
(firefox44 fixed)
RESOLVED
FIXED
FxOS-S8 (02Oct)
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
Details
Attachments
(1 file)
|
4.66 KB,
patch
|
alwu
:
review+
|
Details | Diff | Splinter Review |
AUDIO_STREAM_FM does not exit on aosp android. It was added to caf code. But even on caf, AUDIO_STREAM_FM does not exist anymore. FM radio uses AUDIO_STREAM_MUSIC on flame-kk's code. It is better to undef AUDIO_STREAM_FM after KK.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Comment 1•9 years ago
|
||
FYI: diagram of FMRadioService https://github.com/sotaroikeda/firefox-diagrams/blob/master/dom/dom_media_FMRadioService_FirefoxOS_2_5.pdf
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8663123 -
Flags: review?(alwu)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8663123 [details] [diff] [review] patch - Remove AUDIO_STREAM_FM after KK Review of attachment 8663123 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thank!
Attachment #8663123 -
Flags: review?(alwu) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=79bb412bd374
|
||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d5f8280b630f
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S8 (02Oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•