Closed Bug 1206230 Opened 4 years ago Closed 4 years ago

Add back android:key for Manage Logins

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 43
Tracking Status
firefox42 --- fixed
firefox43 --- fixed

People

(Reporter: liuche, Assigned: liuche)

Details

Attachments

(1 file)

The "Manage Logins" settings item doesn't have a key, so it shows up in telemetry as an empty string which is not useful.

This is my bad, I forgot that we were using android:keys for more than just removing/adding Preference items, so this got removed at my request in bug 1114821.
Bug 1206230 - Add back android:key for Manage Logins. r=mcomella
Attachment #8663129 - Flags: review?(michael.l.comella)
Assignee: nobody → liuche
Comment on attachment 8663129 [details]
MozReview Request: Bug 1206230 - Add back android:key for Manage Logins. r=mcomella

https://reviewboard.mozilla.org/r/19725/#review17753

(In reply to Chenxia Liu [:liuche] from comment #0)
> This is my bad, I forgot that we were using android:keys for more than just
> removing/adding Preference items, so this got removed at my request in bug
> 1114821.

I know nothing about this but that technique seems reasonable.
Attachment #8663129 - Flags: review?(michael.l.comella) → review+
I'm guessing we should uplift this too?
Comment on attachment 8663129 [details]
MozReview Request: Bug 1206230 - Add back android:key for Manage Logins. r=mcomella

Approval Request Comment
[Feature/regressing bug #]: Bug 1114821
[User impact if declined]: Telemetry for the Manage Logins setting will be blank
[Describe test coverage new/current, TreeHerder]: local testing
[Risks and why]: Very low, reverting one line that is in xml
[String/UUID change made/needed]: none

To be clear, this is a r? for 42, which we will probably miss in aurora :/
Attachment #8663129 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/1b227fca027c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Sorry, disregard comment 7 & comment 8. That was for bug 1206203, and I typo'd the bug number in the commit message.
Comment on attachment 8663129 [details]
MozReview Request: Bug 1206230 - Add back android:key for Manage Logins. r=mcomella

Moving the flag to beta since this missed 42 aurora.
Attachment #8663129 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Comment on attachment 8663129 [details]
MozReview Request: Bug 1206230 - Add back android:key for Manage Logins. r=mcomella

Sure, telemetry is good!
Attachment #8663129 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.