1206230 - Add back android:key for Manage Logins

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

The "Manage Logins" settings item doesn't have a key, so it shows up in telemetry as an empty string which is not useful.

This is my bad, I forgot that we were using android:keys for more than just removing/adding Preference items, so this got removed at my request in bug 1114821.

Comment 1

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1206230 - Add back android:key for Manage Logins. r=mcomella

Bug 1206230 - Add back android:key for Manage Logins. r=mcomella

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8663129 [details]
MozReview Request: Bug 1206230 - Add back android:key for Manage Logins. r=mcomella

https://reviewboard.mozilla.org/r/19725/#review17753

(In reply to Chenxia Liu [:liuche] from comment #0)
> This is my bad, I forgot that we were using android:keys for more than just
> removing/adding Preference items, so this got removed at my request in bug
> 1114821.

I know nothing about this but that technique seems reasonable.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I'm guessing we should uplift this too?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1b227fca027c

Comment 5

[Chenxia Liu [:liuche]]

Comment on attachment 8663129 [details]
MozReview Request: Bug 1206230 - Add back android:key for Manage Logins. r=mcomella

Approval Request Comment
[Feature/regressing bug #]: Bug 1114821
[User impact if declined]: Telemetry for the Manage Logins setting will be blank
[Describe test coverage new/current, TreeHerder]: local testing
[Risks and why]: Very low, reverting one line that is in xml
[String/UUID change made/needed]: none

To be clear, this is a r? for 42, which we will probably miss in aurora :/

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1b227fca027c

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b275a63010de

Comment 8

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/b275a63010de

Comment 9

[Daniel Holbert [:dholbert]]

Sorry, disregard comment 7 & comment 8. That was for bug 1206203, and I typo'd the bug number in the commit message.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8663129 [details]
MozReview Request: Bug 1206230 - Add back android:key for Manage Logins. r=mcomella

Moving the flag to beta since this missed 42 aurora.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8663129 [details]
MozReview Request: Bug 1206230 - Add back android:key for Manage Logins. r=mcomella

Sure, telemetry is good!

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/17b396e3f744