Closed Bug 1206300 Opened 9 years ago Closed 9 years ago

Allow immutable prototypes to be disabled at compile time with a single-line change

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

References

Details

Attachments

(1 file)

The immutable-prototype functionality we're adding in bug 1052139 may or may not be immediately shippable.  Make it possible, with a single line of change, to disable it at compile time.  Then, if it turns out not to be immediately shippable, we can make a one-line change to revert it, rather than having to back out a large patch.
Attached patch PatchSplinter Review
I haven't tested this with the immutable-global-prototypes patch in place, but I think it should do the trick.  That'll land second in any event, so this is perfectly fine to take without further ado (assuming tryserver is fine, which I expect it to be).
Attachment #8663190 - Flags: review?(jorendorff)
Attachment #8663190 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/5e0c5de50004
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: