1206437 - Matcher to find duplicate contacts is unlocalized/always in English

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Blocking Requested - why for this release]: Regression

Firefox OS 2.5 20150918150204, Gaia commit 3e9de022, Flame v18D_nightly_v4 base image

The matcher to find duplicate contacts is unlocalized, strings always appear in English.

Steps to reproduce:
1. Open the Contacts app.
2. Create contact Test Test with mail address [e-mail]
3. Create second contact Test Test with phone number [phone]. The app will likely warn of a duplicate, ignore this (haven't checked if the strings have been translated.
4. Open one of the contacts and search for duplicates.
Actual result:
English strings used, e.g. "Suggested duplicate contacts for Test Test" and "Merge with". Happens with German and French, both have been translated:
https://transvision.mozfr.org/string/?entity=apps/communications/contacts/matcher/matcher.properties:suggestedDuplicatesMessage&repo=gaia
https://transvision.mozfr.org/?recherche=merge+with&repo=gaia&sourcelocale=en-US&locale=de&search_type=strings

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Screen Shot 2015-09-22 at 13.27.22.png

Tried with latest master and fake locale and can see the translation.

Marking as worksforme.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The issue can't be reproduced with the pseudo-locales here but with the real locales (B2G 2.5 20150922030227 on Flame).

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Is there a chance that those strings are just not localized in 2.5 yet?

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Heresy! It's French - of course it has been translated ;) (like the rest). German has also no missing strings in the matcher.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Hahaha. Confirmed.

I started investigating - it seems that:

a) the HTML file for matcher is properly built with languages
b) language negotiation is completed and points to fr
c) fr JSON is constructed
d) but it contains en-US strings despite the fact that fr ones are available.

My first guess is that we fail somewhere on l10n-merge.

Stas, any idea what might be going on here?

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Ha, interesting.

[/build_stage/communications/contacts/views/matching/matching_contacts.html] [l10n] L10nError: Not found: /contacts/locales/matcher/matcher.fr.properties (app://communications.gaiamobile.org)

So, basically, the file is in /contacts/views/matching/ and it asks for '/contacts/locales/matcher/matcher.{locale}.properties'.

I'm curious as to why it finds it in source locale, but not in target locale.

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

I got a patch

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1206437-recognize-absolute-paths-in-multilocale > mozilla-b2g:master

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8664422 [details] [review]
[gaia] zbraniecki:1206437-recognize-absolute-paths-in-multilocale > mozilla-b2g:master

I'm in the stage sixth of debugging.

My only guess is that we only used absolute paths for /shared resources so far.

Comment 10

[Staś Małolepszy :stas]

Comment on attachment 8664422 [details] [review]
[gaia] zbraniecki:1206437-recognize-absolute-paths-in-multilocale > mozilla-b2g:master

r=me, thanks for walking me through the code on irc.

Comment 11

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/5f1a5ece7696ab09a896c8dc8fb1fab56f39db49