120644 - Plain text signature is missing on Reply in the quoted body ( plain text mail only)

Status: RESOLVED WORKSFORME

(MailNews Core :: Composition, defect, P2)

Description

[marina]

*** observed with 2002-01-17 build ***
Steps to reproduce:
- have a japanese (maybe all double-byte) newsgroup on your newserver;
(actually i posted one to our i18n.qa newsgroup (one with french accented, one
cyrillic , one in UTF8 and the last one japanese-iso-2022);
- select an article that has a signature file;
- click Reply;
//note : the signature file is ommited from mail composition;
(you can select the last message in i18n.qa newsgroup and click reply); it
deosn't happen when the signature file is french, en-ascii or cyrillic

Comment 1

[marina]

it looks like it happens with plain text signature with latin-1 as well

Comment 2

[marina]

changing summary: happens to all kind of mail (not necessaraly newsgroup, just
plain text signature), core bug

Comment 3

[marina]

Steps to reproduce:
- have a plain text signature file;
- in prefs checked the box to attach it to your mail composition;
- send message with this signature;
- get it, select and click Reply;
//note: the signature file is dropped
Naoki, please reassign to the core team, thanks.

Comment 4

[scottputterman]

reassigning to ducarroz

Comment 5

[esther]

Using build 20020306 on winxp I don't see a problem with plain text signatures.
I tried plain text composing of a message with plain text signature. Sent it,
Received it and Replied to it.  The signature file is there.
I tried HTML composing of a message with plain text signature.  Sent it,
Received it and Replied to it.  The signature file is there.
The only time is see a signature missing is in the quoted part of a plain text
message that was sent to me that is being replied to in plain text with a plain
text signature.   Is this the case you are talking about?

Comment 6

[esther]

Marina, what signature is missing.  The signature that came with the message or
the one you're adding while replying?
If it's the one that came with the message, then let's restate the Summary to
make that clear.  
If it's the signature that gets appened to the message that being replied to
then I don't see that bug in our build. 

Comment 7

[Jean-Francois Ducarroz]

Yes. I did some debugging on it today and for some reason the signature of the
origial message vanishes somewhere inside mime!

Comment 8

[marina]

Since i entered this bug the behavior of the appended signature 's changed and
the only case left is the plain text signature is missing on the reply to a
plain text mail in the quoted body, the one that J-F mentioned.

Comment 9

[marina]

i am looking at the newsarticles now and i see some cases where the signature
file is dropped while you compose a reply . I am attaching two mails ( one
japanese and one cyrillic), copy them to your local mail folder, select a mail
and click reply, you 'll see that the signature file is missing.

Comment 10

[marina]

Attachment: a plain text japanese mail with signature file

Comment 11

[marina]

Attachment: this is a cyrillic plain text mail with signature file

Comment 12

[scottputterman]

can this still be reproduced in a latin-1 email?

Comment 13

[marina]

it is not consistent in non-latin mails, and i can not see the logic behind the
test mails that i attached to this bug report, they all have a link inserted
into the signature but i have others with links that do display a signature
file. In one attached email (japanese) the signature file is ascii, but the body
is japanese. I don't think it's an intl bug though i can not reproduce it with a
simple test case by just composing a plain text signature and appending it to a
plain text mail ( the only one that is reproducable is the one J-F mentionned).
If we can see what's unite the attached two mail that drop the signature while
composing a Reply then i might be able to reproduce it. 

Comment 14

[marina]

i am attaching another mail with signature . It is from german newsgroup
(test.de) and has no non-ascii chars in the body and in the signature but when
clicking reply  the signature file is dropped.

Comment 15

[marina]

Attachment: here is the mail with ascii chars from the german newsgroup

Comment 16

[ji]

Attachment: A plain text us-ascii mail with a signature. I saw the problem with this.

Comment 17

[marina]

Ok, an easy test without copying my attached mails. Go to netscape.public.test,
click on the message posted on  2/18 at 2.07 am from Bull Goose Loony and
observe that there is no signature on reply window.

Comment 18

[esther]

FYI...I don't seem my plain text signature on any of those newsgroup messages if
I click Reply. 

Comment 19

[marina]

i believe that you have to select "attach my signature file" for your news
account. when your settings for the newsaccount have a signature in my
experience it gets attached.

Comment 20

[Michael Buckland]

Discussed in Mail News with Mktng, QA, Engineering and PjM.  Decided to minus
this bug.

Comment 21

[Monte Ohrt]

It seems if there are two dashes by themselves on a line, then that line and
anything past it does not get included in the quote when replying to the
message. (This portion also shows up greyed out in the message display.)

 This is was confirmed using Mozilla 1.0 on Linux, and 1.1 on Windows.

Comment 22

[Mike Cowperthwaite]

Reporter (Marina) never actually provided an answer to the key question raised 
in comment 6.  The signature of the original message is consistently referred to 
as a "signature file" which makes no real sense in this context -- once it's in 
the message, it's no longer a file.  Her comment 8 appears to state that the 
behavior described in comment 7 -- the sig from the original message is not 
included in the quoted text -- is the problem.  (My interpretation is backed up 
by comment 21.)

Is not the stripping of signature by design?  Apprently neither Marina nor Jean-
François believed that to be the case, and yet it seems like an obviously 
desirable thing to do.

I'm going to mark this WFM; if I'm mistaken, I'm sure someone will fix it and 
probably flame me in the process.  See bug 216678 for an RFE to turn off the 
behavior -- apparently desirable for cases where the original message includes 
non-sig content below the sig separator.