Closed
Bug 1206463
Opened 10 years ago
Closed 10 years ago
Eslint cleanup for source editor
Categories
(DevTools :: Source Editor, defect)
DevTools
Source Editor
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
References
Details
Attachments
(1 file, 1 obsolete file)
|
146.11 KB,
patch
|
gl
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8663499 -
Flags: review?(bgrinstead)
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8663499 [details] [diff] [review]
1206463.patch
Review of attachment 8663499 [details] [diff] [review]:
-----------------------------------------------------------------
This will need rebasing on top of Bug 912121. Also, going to redirect the review to Mike, who's been doing a bunch of eslint stuff
Attachment #8663499 -
Flags: review?(bgrinstead) → review?(mratcliffe)
|
||
Comment 4•10 years ago
|
||
@Gabriel: Can you rebase this before I review it?
Flags: needinfo?(gabriel.luong)
|
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8663499 [details] [diff] [review]
1206463.patch
On the other hand, the changes are all fine so you can rebase when you land your changes.
Flags: needinfo?(gabriel.luong)
Attachment #8663499 -
Flags: review?(mratcliffe) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
Attachment #8663499 -
Attachment is obsolete: true
Attachment #8702011 -
Flags: review+
|
||
Comment 8•10 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
|
||
Comment 9•10 years ago
|
||
[bugday-20160323]
Status: RESOLVED,FIXED -> UNVERIFIED
Comments:
STR: Not clear.
Developer specific testing
Component:
Name Firefox
Version 46.0b4
Build ID 20160322075646
Update Channel beta
User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS Windows 7 SP1 x86_64
Expected Results:
Developer specific testing
Actual Results:
As expected
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•