1206571 - Sync UI is in "needs setup" state until first sync

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Mark Hammond [:markh] [:mhammond]]

Bug 1186348 caused a regression, whereby after starting the browser but before Sync has initialized, the UI is in a "needs setup" state. As soon as the sync scheduler starts a Sync it all reverts to correct.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-1206571-ensure-Sync-UI-is-in-correct-state-befor.patch

This removes some nasty hacks in browser-syncui.js by making it use promises - we should have done this a year or 2 ago, but it's now far more viable given we've recently ripped most of browser-syncui out.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=20622311b2c1

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/73d128e70978

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8663557 [details] [diff] [review]
0001-Bug-1206571-ensure-Sync-UI-is-in-correct-state-befor.patch

Approval Request Comment
[Feature/regressing bug #]: 1186348
[User impact if declined]: The Firefox UI will not correctly reflect Sync's state for 10 seconds after Firefox starts.
[Describe test coverage new/current, TreeHerder]: Existing tests pass.
[Risks and why]: Low risk limited to the Sync UI.
[String/UUID change made/needed]: None

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/73d128e70978

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8663557 [details] [diff] [review]
0001-Bug-1206571-ensure-Sync-UI-is-in-correct-state-befor.patch

Has tests, fix for sync timing, let's see how this goes in aurora

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/29a1298aad3d