Closed Bug 1206571 Opened 4 years ago Closed 4 years ago

Sync UI is in "needs setup" state until first sync

Categories

(Firefox :: Sync, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 44
Iteration:
44.1 - Oct 5
Tracking Status
firefox42 --- unaffected
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: markh, Assigned: markh)

References

Details

Attachments

(1 file)

Bug 1186348 caused a regression, whereby after starting the browser but before Sync has initialized, the UI is in a "needs setup" state. As soon as the sync scheduler starts a Sync it all reverts to correct.
Flags: firefox-backlog+
This removes some nasty hacks in browser-syncui.js by making it use promises - we should have done this a year or 2 ago, but it's now far more viable given we've recently ripped most of browser-syncui out.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=20622311b2c1
Assignee: nobody → markh
Status: NEW → ASSIGNED
Attachment #8663557 - Flags: review?(adw)
Attachment #8663557 - Flags: review?(adw) → review+
Iteration: --- → 44.1 - Oct 5
Comment on attachment 8663557 [details] [diff] [review]
0001-Bug-1206571-ensure-Sync-UI-is-in-correct-state-befor.patch

Approval Request Comment
[Feature/regressing bug #]: 1186348
[User impact if declined]: The Firefox UI will not correctly reflect Sync's state for 10 seconds after Firefox starts.
[Describe test coverage new/current, TreeHerder]: Existing tests pass.
[Risks and why]: Low risk limited to the Sync UI.
[String/UUID change made/needed]: None
Attachment #8663557 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/73d128e70978
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment on attachment 8663557 [details] [diff] [review]
0001-Bug-1206571-ensure-Sync-UI-is-in-correct-state-befor.patch

Has tests, fix for sync timing, let's see how this goes in aurora
Attachment #8663557 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.