Closed Bug 1206604 Opened 5 years ago Closed 5 years ago

The split item is only select-able on string, but not the whole field

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:2.5+)

RESOLVED FIXED
blocking-b2g 2.5+

People

(Reporter: gasolin, Assigned: kgrandon)

References

Details

Attachments

(1 file)

Steps:

1. open Settings > Home Screens, or open Settings > Cellular & Data > APN Settings > Data Settings
2. tap the item on the left of the radio panel

result:

not functional when tap outside of text

expect:

move to sub panel when tapped the area on the left of the split bar.
[Blocking Requested - why for this release]: regression of gaia-radio component
blocking-b2g: --- → 2.5?
Blocks 2.5 with a P2 priority
blocking-b2g: 2.5? → 2.5+
Priority: -- → P2
I probably broke this and might take it.
Flags: needinfo?(kevingrandon)
Assignee: nobody → kevingrandon
Status: NEW → ASSIGNED
Flags: needinfo?(kevingrandon)
Comment on attachment 8668279 [details] [review]
[gaia] KevinGrandon:bug_1206604_gaia_radio_split > mozilla-b2g:master

Fred, I think removing duplicate CSS and moving this into the component makes the most sense. Could you please take a look?
Attachment #8668279 - Flags: review?(gasolin)
Comment on attachment 8668279 [details] [review]
[gaia] KevinGrandon:bug_1206604_gaia_radio_split > mozilla-b2g:master

Looks good and it make CSS more maintainable, thanks!
Attachment #8668279 - Flags: review?(gasolin) → review+
In master: https://github.com/mozilla-b2g/gaia/commit/e532e6bf17a2e65997394754576ca23f8a31bf95
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.