1206633 - pretty print broke for...of statement

Status: RESOLVED DUPLICATE of bug 1674400

(DevTools :: Source Editor, defect)

Description

[mozilla]

User Agent: Mozilla/5.0 (Windows NT 6.1; Trident/7.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; .NET4.0C; .NET4.0E; rv:11.0) like Gecko

Steps to reproduce:

1. Load javascript source file with the following code :
for (let tab of tabs) { *\r\n* [...] *\r\n* }
2. Press CTRL+P


Actual results:

Code is formatted like this : 
for (lettaboftabs) { [...]

The code won't work anymore


Expected results:

"let tab of tabs" should have not been touched

Comment 1

[Tom Tromey :tromey]

FWIW I see this in scratchpad but not in the debugger.

Comment 2

[mozbugzi]

Attachment: Patch for pretty-fast

This patch solves the general problem where two name tokens weren't separated by a space in the output. The function isGetterOrSetter is no longer necessary because it's a special case of this problem.

Some minor cosmetic issues remain: this patch will output "for (let tab of[array])". Because "of" isn't a keyword, fixing that would require running a full parser or using imperfect heuristics such as turning "of" into a keyword in the whole argument.

Comment 3

[Tom Tromey :tromey]

Reiterating from https://bugzilla.mozilla.org/show_bug.cgi?id=1261971#c7,
this should go upstream to pretty-fast first.
https://github.com/mozilla/pretty-fast

Comment 4

[Hugh Allen]

I submitted the issue upstream: https://github.com/mozilla/pretty-fast/issues/41

Comment 5

[Hugh Allen]

Nerixyz says:

This is already fixed (commit, test, snap), however the version on npm is out of date and thus is the version used in firefox.

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Just tested and this works properly.
Likely to have been fixed by Bug 1674400