1206639 - Wrong default search engine favicon displayed in BrowserSearch screen

Status: RESOLVED DUPLICATE of bug 1206628

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Device: Moto X (Android 4.4)
Build: Firefox for Android 43.0a1 (2015-09-20)

Steps to reproduce:
(google is the default search engine)
1. Go to Settings -> Customize -> Search 
2. Tap on "Twitter" and select "Set as Default"
3. Open a new tab and tap "test" in the URL Bar

Expected results:
- the word typed at step 3 is displayed with the twitter search engine favicon in BrowserSearch screen 
- search engine works as expected and displays the correct twitter result.

Actual results:
- the word typed at step 3 is displayed with google search engine favicon but the search engine works ok and displays the correct twitter result.
- going once again to Settings -> Customize -> Search and select "Bing" as default search engine and write something in the URL Bar, the word is displayed with "Twitter" favicon, but the search is done through "Bing".

Note:
-good build: 17-09
-bad build: 18-09
pushlog:http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e7d613b3bcfe1e865378bfac37de64560d1234ec&tochange=11dc79e232110ba6de5179e46dfbda77b52a88c3

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Like bug 1206628, I think this is a pre-existing bug uncovered by bug 1186683, which no longer creates BrowserSearch (and thus requests the search engines) each time it is shown. Some possibilities:
  1) We don't update the search engines in Java (i.e. the UI) but when we run a search via the search engine list in Gecko, it uses a positional element so the search occurs as expected even though the UI is not updated to reflect that
  2) We don't correctly update the favicon when the search engine list is updated.

Given bug 1206628, I'd say #1 sounds more correct.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

via IRC – Prabhjyot is interested in fixing the regressions of bug 1186683.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We backed out bug 1186683 from 43.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Prabhjyot, any updates on these regressions? Do you still think finishing them by merge (November 2nd) is reasonable?

Comment 5

[Prabhjyot Sodhi [:psd]]

As discussed on IRC, I have uploaded a patch for bug 1206628 which also fixes this. I do, still think that we will be able to finish these by merge!

Comment 6

[Prabhjyot Sodhi [:psd]]

fixed by bug 1206628