Closed Bug 1206661 Opened 7 years ago Closed 7 years ago

Rewrite usage of Sanitizer to not trigger our eslint rules against innerHTML

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
FxOS-S9 (16Oct)

People

(Reporter: freddy, Assigned: freddy)

References

Details

Attachments

(1 file, 1 obsolete file)

This bug is for rewriting existing instances of the Sanitizer in the system app, using the create/unwrap pattern for "safe html".
Comment on attachment 8663612 [details] [review]
[gaia] mozfreddyb:system-sanitizer-usage > mozilla-b2g:master

Can you take a look or defer to someone else, Tim?

Should be a minimal review, as I merely change the code pattern, not to trip off our eslint rules.
Attachment #8663612 - Flags: review?(timdream)
Assignee: nobody → fbraun
Status: NEW → ASSIGNED
Attachment #8663612 - Flags: review?(timdream) → review+
Squashed commits after a green try and r+, requesting checkin.
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/e028b71dcdbfbae1692bd42163fdfc8ce1d1a704
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
sorry i had to revert this change since this caused https://treeherder.mozilla.org/logviewer.html#?job_id=2848396&repo=b2g-inbound
Status: RESOLVED → REOPENED
Flags: needinfo?(fbraun)
Resolution: FIXED → ---
This can be checked in again, once bug 1209416 lands.
Depends on: 1209416
(I have rebased the commit on master)
Flags: needinfo?(fbraun)
Comment on attachment 8667888 [details] [review]
[gaia] mozfreddyb:system-sanitizer-usage-retry > mozilla-b2g:master

carrying over review, this was just rebased again.
Attachment #8667888 - Flags: review+
Attachment #8663612 - Attachment is obsolete: true
green try-run (except for an intermittent, see bug 1064305) before I squashed the commits:

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=10dc0690b86d776abeaf45b7b4fe7a01e2fb551d
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/8b954dfa901341d581dd879b8ac1070219557980
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S9 (16Oct)
You need to log in before you can comment on or make changes to this bug.