Closed
Bug 1206661
Opened 9 years ago
Closed 9 years ago
Rewrite usage of Sanitizer to not trigger our eslint rules against innerHTML
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S9 (16Oct)
People
(Reporter: freddy, Assigned: freddy)
References
Details
Attachments
(1 file, 1 obsolete file)
This bug is for rewriting existing instances of the Sanitizer in the system app, using the create/unwrap pattern for "safe html".
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8663612 [details] [review]
[gaia] mozfreddyb:system-sanitizer-usage > mozilla-b2g:master
Can you take a look or defer to someone else, Tim?
Should be a minimal review, as I merely change the code pattern, not to trip off our eslint rules.
Attachment #8663612 -
Flags: review?(timdream)
|
||
Updated•9 years ago
|
Assignee: nobody → fbraun
Status: NEW → ASSIGNED
|
|
||
Updated•9 years ago
|
Attachment #8663612 -
Flags: review?(timdream) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Squashed commits after a green try and r+, requesting checkin.
Keywords: checkin-needed
|
||
Comment 4•9 years ago
|
||
|
|
||
Comment 5•9 years ago
|
||
sorry i had to revert this change since this caused https://treeherder.mozilla.org/logviewer.html#?job_id=2848396&repo=b2g-inbound
Status: RESOLVED → REOPENED
Flags: needinfo?(fbraun)
Resolution: FIXED → ---
|
|
Assignee | |
Comment 6•9 years ago
|
||
This can be checked in again, once bug 1209416 lands.
Depends on: 1209416
|
|
||
Comment 8•9 years ago
|
||
|
|
Assignee | |
Comment 9•9 years ago
|
||
Comment on attachment 8667888 [details] [review]
[gaia] mozfreddyb:system-sanitizer-usage-retry > mozilla-b2g:master
carrying over review, this was just rebased again.
Attachment #8667888 -
Flags: review+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8663612 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 10•9 years ago
|
||
green try-run (except for an intermittent, see bug 1064305) before I squashed the commits:
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=10dc0690b86d776abeaf45b7b4fe7a01e2fb551d
Keywords: checkin-needed
|
|
||
Comment 11•9 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S9 (16Oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•