Closed Bug 1206671 Opened 4 years ago Closed 4 years ago

New tab and list all tabs buttons have a gap between their bottom and the navbar on Windows 10

Categories

(Firefox :: Theme, defect, P3)

Product:
Firefox
Component:
Theme
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 44
Tracking Flags:
Tracking Status
firefox42 --- verified
firefox43 --- verified
firefox44 --- verified

People

(Reporter: cornel_ionce, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

remove margin-bottom on toolbarbuttons in the tabbar on windows 10,
2.67 KB, patch
dao
: review+
Sylvestre
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review 
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0

Reproducing on:
* Latest 43.0a1 Nightly, build ID: 20150920030217
* Latest 42.0a2 Aurora, build ID: 20150920004018

STR:
1. Open Firefox.
2. Open several new tabs until the tab bar is overflow.
3. Hover over the "Open A new tab" or "List All tabs" buttons.

Result:
There is 1px between their shadow and the toolbar.

Screenshot: http://i.imgur.com/uQZX4wB.png

Notes:
*This started to reproduce in the 2015-09-10 build, after the fix for bug 1188294 landed.
*This does not reproduce on HiDPI devices (Microsoft Surface Pro 2).
*Not reproducing for the navigation buttons ("<" and ">")
Flags: needinfo?(gijskruitbosch+bugs)
Keywords: regression
Flags: needinfo?(gijskruitbosch+bugs)
Summary: Tab overflow buttons shadows are offset on Windows 10 → New tab and list all tabs buttons have a gap between their bottom and the navbar on Windows 10
Flags: needinfo?(gijskruitbosch+bugs)
Assignee: nobody → gijskruitbosch+bugs
Blocks: 1188294
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #8665466 - Flags: review?(dao) → review+
Priority: -- → P3
https://hg.mozilla.org/mozilla-central/rev/c7cbe7c1ff7f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment on attachment 8665466 [details] [diff] [review]
remove margin-bottom on toolbarbuttons in the tabbar on windows 10,

Approval Request Comment
[Feature/regressing bug #]: bug 1188294
[User impact if declined]: seams between buttons in the tabstrip and the navbar border on win10
[Describe test coverage new/current, TreeHerder]: nope, styling issue
[Risks and why]: low, early 42 cycle, css-only change.
[String/UUID change made/needed]: nope
Attachment #8665466 - Flags: approval-mozilla-beta?
Attachment #8665466 - Flags: approval-mozilla-aurora?
status-firefox42: --- → affected
Comment on attachment 8665466 [details] [diff] [review]
remove margin-bottom on toolbarbuttons in the tabbar on windows 10,

Should be in 42 beta 3.
Attachment #8665466 - Flags: approval-mozilla-beta?
Attachment #8665466 - Flags: approval-mozilla-beta+
Attachment #8665466 - Flags: approval-mozilla-aurora?
Attachment #8665466 - Flags: approval-mozilla-aurora+
Flags: qe-verify+
QA Contact: cornel.ionce
Confirming the fix on Windows 10 32-bit using:
* latest Nightly, build ID: 20150930030231
* lastest Aurora, build ID: 20150930004021.
status-firefox43: fixed → verified
status-firefox44: fixed → verified
Also verified this fix on Firefox 42.0b3, build ID: 20151001142456.
The gap is now properly removed.
Status: RESOLVED → VERIFIED
status-firefox42: fixed → verified
You need to log in before you can comment on or make changes to this bug.