Closed Bug 1206687 Opened 9 years ago Closed 9 years ago

Python setup script points to the pip install/upgrade guide that doesn't exist anymore

Categories

(Testing Graveyard :: JSMarionette, defect)

Product:
Testing Graveyard
Component:
JSMarionette
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: azasypkin, Unassigned)

Details

Attachments

(1 file)

[gaia] azasypkin:bug-1206687-change-pip-install-link > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gaye
: review+
Details | Review 
It's just trivial as it's, seems link to the pip upgrade/install has changed recently that may be confusing for newcomers who try to setup build/test environment for the first time [1].

So likely instead of:

http://pip.readthedocs.org/en/latest/installing.html#install-or-upgrade-pip

we should use:

http://pip.readthedocs.org/en/latest/installing/

[1] https://github.com/mozilla-b2g/gaia/blob/29991414eb94b6baa1ec2e63fdb4f6dfae05fb01/tests/jsmarionette/runner/marionette-js-runner/scripts/setup_python.sh#L58
Comment on attachment 8663626 [details] [review]
[gaia] azasypkin:bug-1206687-change-pip-install-link > mozilla-b2g:master

Hey Gareth,

Here is a tiny patch to correct this. 

How does it look?

Thanks!
Attachment #8663626 - Flags: review?(gaye)
Comment on attachment 8663626 [details] [review]
[gaia] azasypkin:bug-1206687-change-pip-install-link > mozilla-b2g:master

LGTM thanks!
Attachment #8663626 - Flags: review?(gaye) → review+
Landed on master https://github.com/mozilla-b2g/gaia/commit/9936391ba3ede92752f23d66f7d976ed870bd839
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: