Closed
Bug 1206694
Opened 10 years ago
Closed 10 years ago
Don't resync if DataAdapter#update returned false
Categories
(Firefox OS Graveyard :: Sync, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S8 (02Oct)
People
(Reporter: mbdejong, Assigned: mbdejong)
References
Details
Attachments
(1 file)
The DataAdapters in the Sync app resolve their promise with true or false, depending on if something was changed on the kintoCollection. If they return false, we should avoid the second sync.
|
Assignee | |
Updated•10 years ago
|
|
|
||
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8667198 -
Flags: review?(ferjmoreno)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8667198 [details] [review]
[gaia] michielbdejong:1206694-conditional-resync > mozilla-b2g:master
It may be worth documenting this on doc/example-adapter.js
Attachment #8667198 -
Flags: review?(ferjmoreno) → review+
|
|
||
Comment 3•10 years ago
|
||
Michiel, could you rebase the PR, please? Thanks!
Flags: needinfo?(mbdejong)
|
|
Assignee | |
Comment 4•10 years ago
|
||
(In reply to Fernando Jiménez Moreno [:ferjm] from comment #3)
> Michiel, could you rebase the PR, please? Thanks!
Done! Also fixed this line in the test before the new one: https://github.com/mozilla-b2g/gaia/pull/32100/files#diff-567ac0f732417bbbb732d6f76d79347cR239
Flags: needinfo?(mbdejong)
|
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•