1206703 - [css-grid] In an empty grid all lines should be treated as 'auto' for abs.pos. items, i.e. snap to the padding edge

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Mats Palmgren (inactive)]

Attachment: testcase

When there are no in-flow grid items and no explicit grid template properties,
then the grid has no tracks and thus no lines.  So all lines for abs.pos.
items should count as being outside the grid and snap to the corresponding
padding edge.

What we're currently doing is clamp any definite line numbers to the
grid range, which in this case is 1..1, so we wrongly resolve definite
lines to line 1.

We actually have a couple of tests for this, but I failed to recognize
them as failures in bug 1194888. :-(

Comment 1

[Mats Palmgren (inactive)]

Attachment: fix+test

I could add an assertion about this in ToPositionAndLengthForAbsPos()
but I'm not since I have other patches in my queue that will in fact
assert in this case (which is how I found it!).

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5b8bafd2899

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8663659 [details] [diff] [review]
fix+test

r=me

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7e2ac3ffb07c

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7e2ac3ffb07c