One-click search button right-click menu: "search in new tab" logic should be inverted if browser.search.openintab is true

NEW
Unassigned

Status

()

defect
P4
normal
Rank:
45
4 years ago
2 years ago

People

(Reporter: soeren.hentzschel, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox44 affected)

Details

(Whiteboard: [fxsearch])

Reporter

Description

4 years ago
In bug 1110771 a right-click menu for the one-click search buttons was implemented. One of the two actions is "search in new tab". Firefox has a preference to *always* open searches in new tabs (browser.search.openintab). If enabled Firefox should offer a option to "search in same tab" instead because the option to search in a new tab does not make a lot of sense in the right-click menu if Firefox always open searches in new tabs.
What does the content context menu do in that case?
Priority: -- → P4
Whiteboard: [fxsearch]
Reporter

Comment 2

4 years ago
It opens the search result in a new tab, so it's the same as a left-click.
Having a context menu that offers the default action doesn't seem a problem to me, as long as the context menu doesn't do the opposite of what its label says.

Updated

4 years ago
Rank: 45
I can't find the `search in new tab` option in nightly's preference panel.

This issue only make sense if we do expose the `search in new tab` option to user?
Flags: needinfo?(cadeyrn)
Reporter

Comment 5

3 years ago
(In reply to Fred Lin [:gasolin] from comment #4)
> I can't find the `search in new tab` option in nightly's preference panel.
> 
> This issue only make sense if we do expose the `search in new tab` option to
> user?

I don't agree that it only makes sense if the option is exopsed in the user visible preferences. Yes, no visible option means less users with a non-default configuration and that probably means that it's not that important, but it still makes sense to fix it. ;)
Flags: needinfo?(cadeyrn)
Sorry for my word, the bug still makes sense but at least it gets the lower priority
You need to log in before you can comment on or make changes to this bug.