1206968 - One-click search button right-click menu: "search in new tab" logic should be inverted if browser.search.openintab is true

Status: NEW

(Firefox :: Search, defect, P5)

Description

[Sören Hentzschel]

In bug 1110771 a right-click menu for the one-click search buttons was implemented. One of the two actions is "search in new tab". Firefox has a preference to *always* open searches in new tabs (browser.search.openintab). If enabled Firefox should offer a option to "search in same tab" instead because the option to search in a new tab does not make a lot of sense in the right-click menu if Firefox always open searches in new tabs.

Comment 1

[Florian Quèze [:florian]]

What does the content context menu do in that case?

Comment 2

[Sören Hentzschel]

It opens the search result in a new tab, so it's the same as a left-click.

Comment 3

[Florian Quèze [:florian]]

Having a context menu that offers the default action doesn't seem a problem to me, as long as the context menu doesn't do the opposite of what its label says.

Comment 4

[[e-mail]]

I can't find the `search in new tab` option in nightly's preference panel.

This issue only make sense if we do expose the `search in new tab` option to user?

Comment 5

[Sören Hentzschel]

(In reply to Fred Lin [:gasolin] from comment #4)
> I can't find the `search in new tab` option in nightly's preference panel.
> 
> This issue only make sense if we do expose the `search in new tab` option to
> user?

I don't agree that it only makes sense if the option is exopsed in the user visible preferences. Yes, no visible option means less users with a non-default configuration and that probably means that it's not that important, but it still makes sense to fix it. ;)

Comment 6

[[e-mail]]

Sorry for my word, the bug still makes sense but at least it gets the lower priority

Comment 7

[Dale Harvey (:daleharvey)]

Its confusing the search bar has a right click but not the address bar, we will likely want to merge code + behaviour at some point, this is pretty low priority in the meantime