Closed
Bug 1206994
Opened 9 years ago
Closed 9 years ago
[EME] Add PSAPI.dll to the GMP sandbox whitelist
Categories
(Core :: Audio/Video: Playback, defect, P1)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
WONTFIX
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | affected |
People
(Reporter: cpearce, Assigned: cpearce)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.07 KB,
patch
|
bobowen
:
review+
|
Details | Diff | Splinter Review |
Apparently Adobe need this inside their MainConcept decoder for it to work on Vista...
|
Assignee | |
Comment 1•9 years ago
|
||
I've asked Adobe if they can remove the need for this, but we should get the review ball rolling here just in case they can't.
We should hold of landing this until I hear back from Adobe regarding whether they actually can't do without.
Attachment #8663986 -
Flags: review?(bobowen.code)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8663986 [details] [diff] [review]
Patch: Whitelist PSAPI.dll
Review of attachment 8663986 [details] [diff] [review]:
-----------------------------------------------------------------
Looks like these functions are in kernel32.dll after Vista (depending on a setting).
psapi.dll is still currrently loaded in our content processes and Chrome renderer ones on Windows 7 & 10, so I assume loading this won't cause any conflicts.
Attachment #8663986 -
Flags: review?(bobowen.code) → review+
|
||
Comment 3•9 years ago
|
||
cpearce, does Adobe still need you to whitelist psapi.dll for the GMP sandbox? Bob r+'d your patch last week, but you haven't landed it yet.
status-firefox44:
--- → affected
Flags: needinfo?(cpearce)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Adobe have worked around this, we don't need to land this.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(cpearce)
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•