Long-press link menu should offer Send Tab and/or Share

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rnewman, Assigned: johannesmarbach, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

48 bytes, text/x-github-pull-request
sleroux
: review+
tecgirl
: ui-review+
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
Right now the only way to send a page to another device is to load it. Given that there are usually only a couple of things in the menu, Send seems like a good addition.
This seems like a great idea. Do we want only 'Send Tab' to start?
(Reporter)

Comment 2

3 years ago
I'd love the iOS share sheet to be in there; quick access to Pocket/Whatsapp/etc.

That might even be enough as a first step, given that Send Tab will be in the share sheet.
(Assignee)

Comment 3

3 years ago
Created attachment 8687692 [details] [review]
Pull request

This adds a "Share Link" option to the long press action sheet.
Attachment #8687692 - Flags: review?(rnewman)
(Reporter)

Updated

3 years ago
Assignee: nobody → johannesmarbach
Status: NEW → ASSIGNED
(Reporter)

Updated

3 years ago
Attachment #8687692 - Flags: ui-review?(randersen)
Attachment #8687692 - Flags: review?(sleroux)
Attachment #8687692 - Flags: review?(rnewman)
Has this been tested on iPad too?
(Assignee)

Comment 5

3 years ago
(In reply to Stefan Arentz [:st3fan] from comment #4)
> Has this been tested on iPad too?

Good call, Stefan! I just tested on the iPad simulator and found that the second popover (after tapping "Share Link") was not positioned correctly because the tap location was queried too late from the gesture recognizer. I rebased the PR on master and added the fix.
Thank you :-)
Attachment #8687692 - Flags: ui-review?(randersen) → ui-review+
Comment on attachment 8687692 [details] [review]
Pull request

Code looks good - just need one more rebase and Ill give it a test run and merge it in.
(Assignee)

Comment 8

3 years ago
(In reply to Stephan Leroux [:sleroux] from comment #7)
> Code looks good - just need one more rebase and Ill give it a test run and
> merge it in.

Thanks for reviewing, Stephan. I just rebased the PR again.
Thanks for all the rebasing.

master ecbd4ec8490a0fc6bd523da0c71d6257fb3ff9fa
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Attachment #8687692 - Flags: review?(sleroux) → review+
You need to log in before you can comment on or make changes to this bug.