1207068 - Implement ExtendableMessageEvent interface

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Dimi Lee [:dimi]]

ServiceWorker should use extendableMessageEvent interface instead of MessageEvent
according to
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#extendablemessage-event-interface

Comment 1

[Dimi Lee [:dimi]]

Attachment: Implement ExtendableMessageEvent

Comment 2

[Dimi Lee [:dimi]]

Comment on attachment 8685302 [details] [diff] [review]
Implement ExtendableMessageEvent

Set r+ because this patch is already reviewed in bug 1143717 Comment 21.

Comment 3

[Dimi Lee [:dimi]]

try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1aa3a138c450

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9184d15b52be

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9184d15b52be

Comment 6

[Marco Castelluccio [:marco]]

Is this going to be backported to Firefox 44?

Comment 7

[Andrew Overholt [:overholt]]

Do we need it in 44?

Comment 8

[Marco Castelluccio [:marco]]

(For reference, I'm asking because of this: https://github.com/mozilla/serviceworker-cookbook/pull/140#discussion_r46159137)

Comment 9

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8685302 [details] [diff] [review]
Implement ExtendableMessageEvent

Approval Request Comment
[Feature/regressing bug #]: Service workers
[User impact if declined]: We need this to maintain compatibility with chrome in service workers.  Its already been noticed by devs so we should uplift it.
[Describe test coverage new/current, TreeHerder]: Tests included.
[Risks and why]: Minimal.  Only affects service workers.
[String/UUID change made/needed]: None.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8685302 [details] [diff] [review]
Implement ExtendableMessageEvent

SW is planned for 44 and this fix has baked on Nightly for almost ~4 weeks. Let's uplift to Aurora44.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3f7cc875e92e

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/3f7cc875e92e

Comment 13

[Chris Mills [:cmills]]

I've documented this here (see also subpages):

https://developer.mozilla.org/en-US/docs/Web/API/ExtendableMessageEvent

The message event itself is covered here:

https://developer.mozilla.org/en-US/docs/Web/Events/message_%28ServiceWorker%29

And a note has been added to the 44 release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/44#Service_Workers

Let me know if thus makes sense, or if I have got confused here. Thanks!