Implement ExtendableMessageEvent interface

RESOLVED FIXED in Firefox 44

Status

()

defect
RESOLVED FIXED
4 years ago
3 months ago

People

(Reporter: dimi, Assigned: dimi)

Tracking

({dev-doc-complete})

Trunk
mozilla45
x86
Unspecified
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 wontfix, firefox44 fixed, firefox45 fixed, b2g-v2.5 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 years ago
ServiceWorker should use extendableMessageEvent interface instead of MessageEvent
according to
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#extendablemessage-event-interface
Assignee

Updated

4 years ago
Assignee: nobody → dlee
Status: NEW → ASSIGNED
Assignee

Comment 2

4 years ago
Comment on attachment 8685302 [details] [diff] [review]
Implement ExtendableMessageEvent

Set r+ because this patch is already reviewed in bug 1143717 Comment 21.
Attachment #8685302 - Flags: review+
Assignee

Updated

4 years ago
Keywords: checkin-needed

Comment 5

4 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9184d15b52be
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Is this going to be backported to Firefox 44?
Flags: needinfo?(overholt)
Do we need it in 44?
Flags: needinfo?(overholt)
Flags: needinfo?(ehsan)
Flags: needinfo?(dlee)
Flags: needinfo?(catalin.badea392)
Flags: needinfo?(bkelly)
Comment on attachment 8685302 [details] [diff] [review]
Implement ExtendableMessageEvent

Approval Request Comment
[Feature/regressing bug #]: Service workers
[User impact if declined]: We need this to maintain compatibility with chrome in service workers.  Its already been noticed by devs so we should uplift it.
[Describe test coverage new/current, TreeHerder]: Tests included.
[Risks and why]: Minimal.  Only affects service workers.
[String/UUID change made/needed]: None.
Flags: needinfo?(bkelly)
Attachment #8685302 - Flags: approval-mozilla-aurora?
Flags: needinfo?(ehsan)
Flags: needinfo?(dlee)
Flags: needinfo?(catalin.badea392)
Comment on attachment 8685302 [details] [diff] [review]
Implement ExtendableMessageEvent

SW is planned for 44 and this fix has baked on Nightly for almost ~4 weeks. Let's uplift to Aurora44.
Attachment #8685302 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I've documented this here (see also subpages):

https://developer.mozilla.org/en-US/docs/Web/API/ExtendableMessageEvent

The message event itself is covered here:

https://developer.mozilla.org/en-US/docs/Web/Events/message_%28ServiceWorker%29

And a note has been added to the 44 release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/44#Service_Workers

Let me know if thus makes sense, or if I have got confused here. Thanks!
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.