Closed Bug 1207068 Opened 5 years ago Closed 5 years ago
Message Event interface
ServiceWorker should use extendableMessageEvent interface instead of MessageEvent according to https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#extendablemessage-event-interface
Assignee: nobody → dlee
Comment on attachment 8685302 [details] [diff] [review] Implement ExtendableMessageEvent Set r+ because this patch is already reviewed in bug 1143717 Comment 21.
Attachment #8685302 - Flags: review+
Is this going to be backported to Firefox 44?
5 years ago
Do we need it in 44?
(For reference, I'm asking because of this: https://github.com/mozilla/serviceworker-cookbook/pull/140#discussion_r46159137)
Comment on attachment 8685302 [details] [diff] [review] Implement ExtendableMessageEvent Approval Request Comment [Feature/regressing bug #]: Service workers [User impact if declined]: We need this to maintain compatibility with chrome in service workers. Its already been noticed by devs so we should uplift it. [Describe test coverage new/current, TreeHerder]: Tests included. [Risks and why]: Minimal. Only affects service workers. [String/UUID change made/needed]: None.
Attachment #8685302 - Flags: approval-mozilla-aurora?
Comment on attachment 8685302 [details] [diff] [review] Implement ExtendableMessageEvent SW is planned for 44 and this fix has baked on Nightly for almost ~4 weeks. Let's uplift to Aurora44.
Attachment #8685302 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I've documented this here (see also subpages): https://developer.mozilla.org/en-US/docs/Web/API/ExtendableMessageEvent The message event itself is covered here: https://developer.mozilla.org/en-US/docs/Web/Events/message_%28ServiceWorker%29 And a note has been added to the 44 release notes: https://developer.mozilla.org/en-US/Firefox/Releases/44#Service_Workers Let me know if thus makes sense, or if I have got confused here. Thanks!
You need to log in before you can comment on or make changes to this bug.