1207088 - Don't show the "Pick Folder..." button for a directory picking <input> on platforms that don't have a directory picker

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jonathan Watt [:jwatt]]

Right now <input type=file directory> shows both the "Pick Files..." and the "Pick Folder..." buttons in Firefox for Android and Firefox OS. Neither platforms have a directory picker, so we shouldn't show the "Pick Folder..." button even if the dom.input.dirpicker pref is true.

Comment 1

[Jonathan Watt [:jwatt]]

Note that the code in HTMLInputElement::ChooseDirectory redirects a click on "Pick Folder..." to open the file picker on these platforms, but from a user's perspective we shouldn't even show the button.

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: button

Comment 3

[Jonathan Kew [:jfkthame]]

Comment on attachment 8664155 [details] [diff] [review]
button

Review of attachment 8664155 [details] [diff] [review]:
-----------------------------------------------------------------

I guess this makes sense for now, though I hope we'll eventually have a better story for those platforms.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/19320abf76b1

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/2e41ed832f7e for Werror bustage: 
https://treeherder.mozilla.org/logviewer.html#?job_id=14517369&repo=mozilla-inbound

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e7598ff5a9f

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4e7598ff5a9f

Comment 8

[Jonathan Watt [:jwatt]]

The webkitdirectory solution that got shipped didn't implement two buttons.