Closed Bug 1207088 Opened 4 years ago Closed 4 years ago

Don't show the "Pick Folder..." button for a directory picking <input> on platforms that don't have a directory picker

Categories

(Core :: Layout: Form Controls, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

Right now <input type=file directory> shows both the "Pick Files..." and the "Pick Folder..." buttons in Firefox for Android and Firefox OS. Neither platforms have a directory picker, so we shouldn't show the "Pick Folder..." button even if the dom.input.dirpicker pref is true.
Note that the code in HTMLInputElement::ChooseDirectory redirects a click on "Pick Folder..." to open the file picker on these platforms, but from a user's perspective we shouldn't even show the button.
Attached patch buttonSplinter Review
Attachment #8664155 - Attachment is patch: true
Attachment #8664155 - Flags: review?(jfkthame)
Component: Widget → Layout: Form Controls
Version: 37 Branch → Trunk
Comment on attachment 8664155 [details] [diff] [review]
button

Review of attachment 8664155 [details] [diff] [review]:
-----------------------------------------------------------------

I guess this makes sense for now, though I hope we'll eventually have a better story for those platforms.
Attachment #8664155 - Flags: review?(jfkthame) → review+
https://hg.mozilla.org/mozilla-central/rev/4e7598ff5a9f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
The webkitdirectory solution that got shipped didn't implement two buttons.
Flags: needinfo?(jwatt)
You need to log in before you can comment on or make changes to this bug.